ci: run full ui package tests#870
Conversation
|
Warning Review limit reached
Your plan currently allows 1 review/hour. Refill in 41 minutes and 21 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Perf delta summaryComparator: pass
|
There was a problem hiding this comment.
Code Review
This pull request integrates the ui package into the CI workflow by adding a test:ci script, updating the Turbo configuration, and adjusting relevant CI tests. It also updates the styling for IconButton and Button components to align with updated design specifications, including changes to dimensions and border radii. Feedback suggests expanding the CI workflow test to verify the dependsOn property in the Turbo task configuration for better pipeline correctness.
Summary
Run the full
packages/uipackage test suite in CI instead of only the focused tests underpackages/ui/test.Why
packages/ui/src/**already contains package-level tests, but CI did not invoke a UI packagetest:citask. That left 34 source-adjacent tests silent on pull requests.Related Issue
Closes #869
Human Review Status
Pending
Review Focus
Please focus on whether the new
unit-uijob and Turbo@opencode-ai/ui#test:citask cover the intended UI package tests without widening CI scope beyond the package boundary.Risk Notes
Low risk: this changes CI coverage and aligns two UI control assertions with the current design tokens. No runtime dependency or platform packaging behavior changed.
Skipped conditional checklist items:
How To Verify
Screenshots or Recordings
Visual check performed with
bun run snap sidebar; revieweddocs/design/preview/screenshots/sidebar.pnglocally for the changed sidebar/titlebar control styling.Checklist
bug,enhancement,task,documentation. Type labels are author-added; the labeler bot does NOT assign them. Add the label in the GitHub UI, then tick this.app,ui,platform,harness,ci. The labeler bot assigns these on PR open based on changed paths. Confirm the bot's choice (or override if wrong), then tick this.P0,P1,P2,P3. The priority-triage bot suggests one on PR open. Confirm or override, then tick this.Pending,Approved by @<reviewer>, orNot required: <reason>(default isPending; "not required" is restricted to bot-authored low-risk PRs).dev, and my PR title and commit messages use Conventional Commits in English.