Skip to content

ci: run full ui package tests#870

Merged
Astro-Han merged 4 commits into
devfrom
codex/i869-ui-ci
May 23, 2026
Merged

ci: run full ui package tests#870
Astro-Han merged 4 commits into
devfrom
codex/i869-ui-ci

Conversation

@Astro-Han

Copy link
Copy Markdown
Owner

Summary

Run the full packages/ui package test suite in CI instead of only the focused tests under packages/ui/test.

Why

packages/ui/src/** already contains package-level tests, but CI did not invoke a UI package test:ci task. That left 34 source-adjacent tests silent on pull requests.

Related Issue

Closes #869

Human Review Status

Pending

Review Focus

Please focus on whether the new unit-ui job and Turbo @opencode-ai/ui#test:ci task cover the intended UI package tests without widening CI scope beyond the package boundary.

Risk Notes

Low risk: this changes CI coverage and aligns two UI control assertions with the current design tokens. No runtime dependency or platform packaging behavior changed.

Skipped conditional checklist items:

  • Platform impact: no platform, packaging, updater, signing, path, shell, or permissions surface was touched.
  • Docs/release/dependency/local artifact impact: no docs, release notes, dependencies, credentials, deletion behavior, generated content, or local artifacts were committed.

How To Verify

bun --cwd packages/opencode test test/github/ci-workflow.test.ts
Result: 11 passed, 0 failed.

bun turbo test:ci --filter=@opencode-ai/ui --dry=json | jq -r '.tasks[].taskId'
Result: includes @opencode-ai/ui#test:ci, with build dependencies only.

bun turbo test:ci --filter=@opencode-ai/ui
Result: 648 passed, 0 failed across 51 files.

bun run snap sidebar
Result: 1 passed; reviewed the generated sidebar preview locally.

Screenshots or Recordings

Visual check performed with bun run snap sidebar; reviewed docs/design/preview/screenshots/sidebar.png locally for the changed sidebar/titlebar control styling.

Checklist

How to use this checklist:

  • Tick a box by replacing [ ] with [x]. Do not edit, add, or remove items.
  • The bot-applied label items can only be honestly ticked AFTER the PR is opened and the labeler / priority-triage bots have run — return to the PR description and tick them then.
  • Most items are required. The few that are conditional are explicitly marked (conditional); for those, leave unticked if they truly do not apply and explain why in Risk Notes. All other items must be ticked before requesting human review.
  • Type label — this PR carries exactly one of bug, enhancement, task, documentation. Type labels are author-added; the labeler bot does NOT assign them. Add the label in the GitHub UI, then tick this.
  • Routing labels — this PR carries at least one of app, ui, platform, harness, ci. The labeler bot assigns these on PR open based on changed paths. Confirm the bot's choice (or override if wrong), then tick this.
  • Priority label — this PR carries exactly one of P0, P1, P2, P3. The priority-triage bot suggests one on PR open. Confirm or override, then tick this.
  • Human Review Status above is set to Pending, Approved by @<reviewer>, or Not required: <reason> (default is Pending; "not required" is restricted to bot-authored low-risk PRs).
  • I linked the related issue, or stated in Summary why there is no issue.
  • I described the review focus and any meaningful risks.
  • I replaced the example block in How To Verify with the real verification steps and the key result for each.
  • I did not introduce unrelated refactors, dependencies, generated files, or file changes beyond the stated scope.
  • (conditional) I manually checked visible UI or copy changes when needed, with screenshots or recordings. Leave unticked only if no visible UI or copy changed.
  • (conditional) I considered macOS and Windows impact for platform, packaging, updater, signing, paths, shell, or permissions changes. Leave unticked only if no platform/packaging surface was touched.
  • (conditional) I called out docs, release notes, dependencies, permissions, credentials, deletion behavior, generated content, or local file changes when relevant. Leave unticked only if none of those surfaces was touched.
  • I reviewed the final diff for unrelated changes and suspicious dependency changes.
  • I am targeting dev, and my PR title and commit messages use Conventional Commits in English.

@Astro-Han Astro-Han added ci Continuous integration / GitHub Actions P2 Medium priority ui Design system and user interface task Narrow execution, audit, spike, migration, tracking, or upstream follow-up work labels May 23, 2026
@coderabbitai

coderabbitai Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Astro-Han, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 41 minutes and 21 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ea90c493-248e-4e35-b2cd-c17322110208

📥 Commits

Reviewing files that changed from the base of the PR and between d528ab8 and 1810f4c.

📒 Files selected for processing (9)
  • .github/workflows/ci.yml
  • packages/opencode/test/github/ci-workflow.test.ts
  • packages/ui/package.json
  • packages/ui/src/components/icon-button.css
  • packages/ui/src/components/message-part-stale.test.ts
  • packages/ui/src/components/session-turn.css
  • packages/ui/test/button-states.test.ts
  • packages/ui/test/icon-button-states.test.ts
  • turbo.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/i869-ui-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the harness Model harness, prompts, tool descriptions, and session mechanics label May 23, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested priority: P2 (includes non-doc, non-test paths outside the low-risk bucket).

P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.

@github-actions

github-actions Bot commented May 23, 2026

Copy link
Copy Markdown

Perf delta summary

Comparator: pass

Profile / Scenario interaction median interaction worst long task max tbt frame gap p95 frame gap max jank count cls status
default / homepage-cold 48 -> 24 (-24) 48 -> 40 (-8) 84 -> 63 (-21) 34 -> 13 (-21) 33.4 -> 16.8 (-16.6) 133.4 -> 183.3 (+49.9) 4 -> 2 (-2) 0 -> 0 (0) pass
default / long-session-input-lag 48 -> 48 (0) 48 -> 64 (+16) 0 -> 0 (0) 0 -> 0 (0) 16.7 -> 16.8 (+0.1) 16.8 -> 16.8 (0) 0 -> 0 (0) 0 -> 0 (0) pass
default / session-streaming-long 56 -> 48 (-8) 64 -> 72 (+8) 0 -> 0 (0) 0 -> 0 (0) 16.8 -> 33.4 (+16.6) 33.4 -> 50.1 (+16.7) 0 -> 1 (+1) 0 -> 0 (0) pass
default / tool-call-expand 16 -> 16 (0) 24 -> 24 (0) 0 -> 0 (0) 0 -> 0 (0) 16.7 -> 16.7 (0) 16.7 -> 16.7 (0) 0 -> 0 (0) 0 -> 0 (0) pass
default / tool-default-open-heavy-bash 16 -> 16 (0) 24 -> 24 (0) 69 -> 72 (+3) 19 -> 34 (+15) 50 -> 66.6 (+16.6) 116.7 -> 116.7 (0) 2 -> 4 (+2) 0 -> 0 (0) pass
default / terminal-side-panel-open 48 -> 48 (0) 48 -> 48 (0) 0 -> 0 (0) 0 -> 0 (0) 16.8 -> 33.3 (+16.5) 33.4 -> 33.4 (0) 0 -> 0 (0) 0 -> 0 (0) pass
default / session-scroll-reading 16 -> 16 (0) 32 -> 16 (-16) 0 -> 0 (0) 0 -> 0 (0) 33.3 -> 33.3 (0) 33.3 -> 33.3 (0) 0 -> 0 (0) 0 -> 0 (0) pass

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates the ui package into the CI workflow by adding a test:ci script, updating the Turbo configuration, and adjusting relevant CI tests. It also updates the styling for IconButton and Button components to align with updated design specifications, including changes to dimensions and border radii. Feedback suggests expanding the CI workflow test to verify the dependsOn property in the Turbo task configuration for better pipeline correctness.

Comment thread packages/opencode/test/github/ci-workflow.test.ts
@Astro-Han Astro-Han merged commit c2dc7f2 into dev May 23, 2026
27 checks passed
@Astro-Han Astro-Han deleted the codex/i869-ui-ci branch May 23, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration / GitHub Actions harness Model harness, prompts, tool descriptions, and session mechanics P2 Medium priority task Narrow execution, audit, spike, migration, tracking, or upstream follow-up work ui Design system and user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 34 tests under packages/ui/src/** are silently excluded from CI

1 participant