Skip to content

fix: align chrome sidebar icon stroke density#621

Merged
Astro-Han merged 1 commit into
devfrom
codex/i523-icon-stroke
May 14, 2026
Merged

fix: align chrome sidebar icon stroke density#621
Astro-Han merged 1 commit into
devfrom
codex/i523-icon-stroke

Conversation

@Astro-Han

Copy link
Copy Markdown
Owner

Summary

Aligns confirmed chrome/sidebar icon density outliers in the shared Icon registry so they read more consistently at 16px sidebar rows and 20px controls.

Updated icons: new-session, branch, worktree, models, link, github, code, code-lines, bubble-5, and glasses.

Why

Closes #523.

The audit found several traced fill icons with lower or mismatched perceived stroke density. new-session was the clearest outlier, and additional chrome/sidebar icons had similar 16px/20px balance issues. branch and link were regenerated from the approved imagegen/Potrace candidates, then adjusted to avoid the too-heavy/clipped result from the first pass.

Related Issue

Closes #523

Human Review Status

Pending. A human should make the final merge decision after reviewing the final diff and verification evidence.

Review Focus

Please focus on the 16px and 20px perceived density of the updated icons, especially new-session, branch, link, code, code-lines, bubble-5, and glasses.

Risk Notes

UI-only SVG path replacements in packages/ui/src/components/icon.tsx. No message flow, Session Timeline, scroll logic, state, data, dependencies, or generated assets are changed.

file-tree was left unchanged: the earlier black-block symptom was a local preview fill-rule/import issue, not a product icon defect.

How To Verify

UI typecheck: bun --cwd packages/ui typecheck -> passed (tsgo --noEmit)
App typecheck: bun --cwd packages/app typecheck -> passed (tsgo -b)
Diff check: git diff --check -> passed
Comparison preview: refreshed and checked _chrome-sidebar-icon-before-after.html at 16 / 20 / 40 / 72 px
Electron manual check: PAWWORK_CI_SMOKE=true PAWWORK_CI_SMOKE_HOME=/tmp/pawwork-i523-electron-pr-smoke bun run dev:desktop -> verified dev Electron (com.github.Electron, localhost:5173) home/sidebar/settings chrome renders

Screenshots or Recordings

Visible UI was checked locally with the generated before/after comparison page:

/Users/yuhan/workspace/dev/pawwork/docs/design/preview/_chrome-sidebar-icon-before-after.html
/tmp/pawwork-i523-before-after-branch-link-refined.png

The preview artifacts are local-only and intentionally not committed.

Checklist

  • Human review status is stated above as pending, approved, or not required
  • I linked the related issue, or stated why there is no issue
  • This PR has type, primary area, and priority labels, or I requested maintainer labeling
  • I described the review focus and any meaningful risks
  • I listed the relevant verification steps and the key result for each
  • I did not introduce unrelated refactors, dependencies, generated files, or file changes beyond the stated scope
  • I manually checked visible UI or copy changes when needed, with screenshots or recordings
  • I considered macOS and Windows impact for platform, packaging, updater, signing, paths, shell, or permissions changes
  • I called out docs, release notes, dependencies, permissions, credentials, deletion behavior, generated content, or local file changes when relevant
  • I reviewed the final diff for unrelated changes and suspicious dependency changes
  • I am targeting dev, and my PR title and commit messages use Conventional Commits in English

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@Astro-Han has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minute and 28 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c17c098d-a0da-4479-9f83-ca797e839b40

📥 Commits

Reviewing files that changed from the base of the PR and between 25d9ee4 and ecfeec9.

📒 Files selected for processing (1)
  • packages/ui/src/components/icon.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/i523-icon-stroke

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the ui Design system and user interface label May 14, 2026
@Astro-Han Astro-Han added enhancement New feature or request P3 Low priority labels May 14, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested priority: P2 (includes non-doc, non-test paths outside the low-risk bucket).

P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.

@github-actions

Copy link
Copy Markdown

Perf delta summary

Comparator: pass

Profile / Scenario interaction median interaction worst long task max tbt frame gap p95 frame gap max jank count cls status
default / homepage-cold 40 -> 24 (-16) 80 -> 72 (-8) 87 -> 62 (-25) 37 -> 12 (-25) 16.8 -> 16.8 (0) 183.3 -> 116.7 (-66.6) 3 -> 3 (0) 0 -> 0 (0) pass
default / session-streaming-long 48 -> 56 (+8) 72 -> 64 (-8) 111 -> 0 (-111) 61 -> 0 (-61) 33.2 -> 33.3 (+0.1) 116.6 -> 33.4 (-83.2) 1 -> 0 (-1) 0 -> 0 (0) pass
default / tool-call-expand 16 -> 16 (0) 16 -> 16 (0) 0 -> 0 (0) 0 -> 0 (0) 16.7 -> 16.7 (0) 16.7 -> 16.7 (0) 0 -> 0 (0) 0 -> 0 (0) pass
default / terminal-side-panel-open 48 -> 40 (-8) 48 -> 48 (0) 0 -> 0 (0) 0 -> 0 (0) 16.8 -> 16.8 (0) 33.3 -> 16.8 (-16.5) 0 -> 0 (0) 0 -> 0 (0) pass
default / session-scroll-reading 16 -> 16 (0) 24 -> 24 (0) 0 -> 0 (0) 0 -> 0 (0) 16.7 -> 16.7 (0) 16.7 -> 16.7 (0) 0 -> 0 (0) 0.505 -> 0.505 (0) warn: cls

@Astro-Han Astro-Han merged commit 8c79fac into dev May 14, 2026
26 checks passed
@Astro-Han Astro-Han deleted the codex/i523-icon-stroke branch May 14, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request P3 Low priority ui Design system and user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Audit and align chrome/sidebar icon size and stroke consistency

1 participant