test(app): stabilize session composer dock e2e#539
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds new E2E test utilities to the session-composer-dock spec file: a ChangesE2E Scroll-Dock Test Utilities and Regression Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces helper functions seedSessionTurns and scrollTimelineAwayFromBottom to the E2E test suite for the session composer dock. These helpers improve test reliability and readability by standardizing how session data is seeded and how scroll behavior is simulated. Additionally, the PR updates existing tests to use these helpers, adds explicit focus calls before keyboard interactions, and expands test data for question options. As there were no review comments provided, I have no feedback to offer.
Summary
Stabilizes the session composer dock E2E coverage for #529 by replacing brittle scroll gestures and invalid one-option question seeds with deterministic test setup.
Why
The remaining #529
session-composer-dockslice was not a reliable user-path test:Endwithout focusing the question options, so it did not exercise the dock's keyboard path deterministically.This PR keeps the product code unchanged and makes the existing E2E assertions match stable user paths.
Related Issue
Refs #529.
Human Review Status
Pending. A human should make the final merge decision after reviewing the final diff and verification evidence.
Review Focus
seedSessionTurns()helper only creates deterministic scrollable history for this spec.scrollTimelineAwayFromBottom()now explicitly marks an upward wheel intent before moving the timeline, so the test exercises user-scrolled dock resize behavior instead of relying on flaky pointer placement.Risk Notes
Low risk. This is E2E-only test stabilization with no product code, schema, dependency, or generated-file changes.
How To Verify
Screenshots or Recordings
Not applicable. E2E-only test stabilization, no visible product UI change.
Checklist
dev, and my PR title and commit messages use Conventional Commits in EnglishSummary by CodeRabbit