Skip to content

feat: sync shared and UI primitive layers for 9b#49

Merged
Astro-Han merged 7 commits into
devfrom
codex/sync-nonui-primitives
Apr 20, 2026
Merged

feat: sync shared and UI primitive layers for 9b#49
Astro-Han merged 7 commits into
devfrom
codex/sync-nonui-primitives

Conversation

@Astro-Han

@Astro-Han Astro-Han commented Apr 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • add packages/shared/** and keep packages/util/** as a compatibility layer with focused surface tests
  • sync the upstream-backed non-app primitive slice across packages/ui/**, packages/plugin/**, packages/sdk/js/**, and packages/function/**
  • include a small amount of PawWork-side reconciliation around review and right-panel behavior where landing the primitive sync on current dev exposed regressions

Why

PR 9b is still primarily the non-app primitive sync slice for issue #27. Most of the diff is direct upstream intake in the 9b-owned layer.

A smaller portion of the branch is local reconciliation work that got mixed in because the primitive sync surfaced review and right-panel regressions on current PawWork. Those follow-up fixes are not meant as a separate product feature; they are here to keep the synced primitive layer usable on top of current dev.

This PR is not intended as a broad product-surface expansion. In particular, upstream library inventory under packages/ui such as extra locale or theme files is not the reason this PR exists and should not be treated as the core value of the slice.

Scope Note

The branch is not a perfectly pure cherry-pick stack. In addition to upstream-backed package sync, it also contains:

  • focused reconciliation in packages/ui/** for review and right-panel behavior
  • matching regression coverage in packages/app/e2e/** and packages/app/src/pages/session/** for those reconciliation paths

Review should focus on whether the mixed-in local fixes are direct sync fallout and whether the branch still avoids broad scope expansion beyond the 9b lane.

Related Issue

Part of #27

How To Verify

bun run typecheck
cd packages/shared && bun test test
cd packages/util && bun test test
cd packages/app && bun test --preload ./happydom.ts ./src/pages/session/right-panel-tabs.test.ts ./src/pages/session/session-side-panel.test.tsx ./src/theme-preload.test.ts
cd packages/app && bunx playwright test e2e/session/session-review.spec.ts e2e/commands/panels.spec.ts --grep "review file comments submit on click without clipping actions|review keeps added files actionable in the review list|review hides open-file actions for deleted files|review keeps open-file actions for modified files emptied to blank|desktop right-panel shell tabs keep the sidepanel chrome contract|desktop session keeps a single right-panel toggle and icon-first utility tabs"
rg -n '"PawWork"|content="PawWork"' packages/ui/src/assets/favicon/site.webmanifest packages/ui/src/components/favicon.tsx

Screenshots or Recordings

Not attached. Visual changes are limited to restoring existing review and right-panel behavior, and the affected UI paths are covered by focused Playwright tests.

Checklist

  • I ran the relevant verification steps
  • I tested visible changes manually when needed
  • I am targeting the dev branch

Comment thread packages/shared/src/util/identifier.ts Fixed
@Astro-Han Astro-Han merged commit 1c8181f into dev Apr 20, 2026
11 checks passed
@Astro-Han Astro-Han deleted the codex/sync-nonui-primitives branch April 20, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants