Skip to content

fix(app): restore session timeline width cap#483

Merged
Astro-Han merged 2 commits into
devfrom
codex/i479-restore-timeline-width
May 6, 2026
Merged

fix(app): restore session timeline width cap#483
Astro-Han merged 2 commits into
devfrom
codex/i479-restore-timeline-width

Conversation

@Astro-Han

@Astro-Han Astro-Han commented May 6, 2026

Copy link
Copy Markdown
Owner

Summary

Restore the session timeline medium-width cap to the explicit 800px value from #464, and add a right-panel-hidden regression assertion at 1280px.

Why

Fixes #479.

#464 fixed #456 by changing the session timeline from md:max-w-200 to md:max-w-[800px], because PawWork's 13px root font makes max-w-200 resolve to about 650px. The composer remains capped at 720px in the same viewport band, so the old timeline cap makes the composer visibly wider than the message flow.

The regression was reintroduced during the #440 UI slice merge chain: #461 first changed the two timeline caps back to md:max-w-200, and #460 later kept that same file state while removing dead delete-session code from message-timeline.tsx.

Related Issue

Closes #479

Human Review Status

Pending. A human should make the final merge decision after reviewing the final diff and verification evidence.

Review Focus

Check that this only restores the lost timeline width cap and adds one focused right-panel-hidden coverage point. It does not change composer sizing, right-panel behavior, or broader layout tokens.

Risk Notes

Low. This is a two-line session layout restore plus one E2E coverage point. It does not touch persistence, packaging, permissions, dependencies, or platform code.

How To Verify

Red check: with the old md:max-w-200 cap temporarily restored, the focused E2E failed at the new 1280px/right-panel-hidden checkpoint with timeline 651px vs composer 720px
Focused E2E: passed with bun --cwd packages/app test:e2e e2e/app/session.spec.ts -g "session timeline visible content is not narrower than composer shell"
Typecheck: passed with bun --cwd packages/app typecheck
Diff check: no whitespace errors with git diff --check

Screenshots or Recordings

Not attached. The regression E2E now explicitly asserts #right-panel[aria-hidden="true"] at 1280px and verifies the timeline/composer bounding-box contract.

Checklist

  • Human review status is stated above as pending, approved, or not required
  • I linked the related issue, or stated why there is no issue
  • This PR has type, primary area, and priority labels, or I requested maintainer labeling
  • I described the review focus and any meaningful risks
  • I listed the relevant verification steps and the key result for each
  • I did not introduce unrelated refactors, dependencies, generated files, or file changes beyond the stated scope
  • I manually checked visible UI or copy changes when needed, with screenshots or recordings
  • I considered macOS and Windows impact for platform, packaging, updater, signing, paths, shell, or permissions changes
  • I called out docs, release notes, dependencies, permissions, credentials, deletion behavior, generated content, or local file changes when relevant
  • I reviewed the final diff for unrelated changes and suspicious dependency changes
  • I am targeting dev, and my PR title and commit messages use Conventional Commits in English

@coderabbitai

coderabbitai Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@Astro-Han has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 40 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4fc78895-995c-49ff-be84-ebbecc0e3cca

📥 Commits

Reviewing files that changed from the base of the PR and between b917193 and 11f27b0.

📒 Files selected for processing (2)
  • packages/app/e2e/app/session.spec.ts
  • packages/app/src/pages/session/message-timeline.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/i479-restore-timeline-width

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Astro-Han Astro-Han added bug Something isn't working P1 High priority ui Design system and user interface labels May 6, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the maximum width of the message timeline and its components from md:max-w-200 to md:max-w-[800px] when the centered prop is active. I have no feedback to provide.

@Astro-Han Astro-Han merged commit 79084aa into dev May 6, 2026
22 checks passed
@Astro-Han Astro-Han deleted the codex/i479-restore-timeline-width branch May 6, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working P1 High priority ui Design system and user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Composer still wider than timeline in some layouts (follow-up to #464)

1 participant