packages/app/src/pages/layout/shell-navigation.test.ts (1)

54-67: ⚡ Quick win

Add the explicit-directory fallback case too.

This only exercises the currentProjectRoot() failure path because openNewSession() is called without an argument. The sibling branch for resolveProjectRoot(directory) is still unpinned when an explicit directory cannot be resolved.

🧪 Suggested companion test

   test("falls back to project chooser when no directory can be resolved for a new session", () => {
     const calls: string[] = []
     const shell = createShellNavigation({
       navigate: (route) => calls.push(`navigate:${route}`),
       releaseTransientLocks: (reason) => calls.push(`release:${reason}`),
       resolveProjectRoot: () => "",
       currentProjectRoot: () => undefined,
       chooseProject: () => calls.push("chooseProject"),
       openSettingsSurface: () => calls.push("settings"),
     })

     shell.openNewSession()

     expect(calls).toEqual(["release:new-session", "chooseProject"])
   })
+
+  test("falls back to project chooser when an explicit directory cannot be resolved", () => {
+    const calls: string[] = []
+    const shell = createShellNavigation({
+      navigate: (route) => calls.push(`navigate:${route}`),
+      releaseTransientLocks: (reason) => calls.push(`release:${reason}`),
+      resolveProjectRoot: () => undefined,
+      currentProjectRoot: () => "/current",
+      chooseProject: () => calls.push("chooseProject"),
+      openSettingsSurface: () => calls.push("settings"),
+    })
+
+    shell.openNewSession("/repo")
+
+    expect(calls).toEqual(["release:new-session", "chooseProject"])
+  })

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/app/src/pages/layout/shell-navigation.test.ts` around lines 54 - 67,
Add a companion test that exercises the explicit-directory fallback path:
createShellNavigation with resolveProjectRoot returning "" and
currentProjectRoot returning undefined (or as appropriate), then call
shell.openNewSession("/some/dir") (i.e., pass an explicit directory) and assert
the calls include releasing transient locks and choosing project (e.g.,
["release:new-session","chooseProject"]); this ensures the
resolveProjectRoot(directory) branch is covered in addition to the existing
currentProjectRoot() failure path. Use the same helpers (createShellNavigation,
resolveProjectRoot, currentProjectRoot, chooseProject, openNewSession) and
mirror the structure of the existing test.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

packages/app/src/pages/layout/shell-navigation.test.ts (1)

54-66: ⚡ Quick win

resolveProjectRoot mock in this case is not exercised.

On Line 65, openNewSession() is called without a directory, so Line 59’s resolveProjectRoot: () => "" never runs. This makes the setup misleading and leaves the explicit-directory + empty-string fallback path untested.

♻️ Suggested test adjustment

-  test("falls back to project chooser when no directory can be resolved for a new session", () => {
+  test("falls back to project chooser when explicit directory resolves to empty root", () => {
     const calls: string[] = []
     const shell = createShellNavigation({
       navigate: (route) => calls.push(`navigate:${route}`),
       releaseTransientLocks: (reason) => calls.push(`release:${reason}`),
       resolveProjectRoot: () => "",
       currentProjectRoot: () => undefined,
       chooseProject: () => calls.push("chooseProject"),
       openSettingsSurface: () => calls.push("settings"),
     })
 
-    shell.openNewSession()
+    shell.openNewSession("/repo")
 
     expect(calls).toEqual(["release:choose-project", "chooseProject"])
   })

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/app/src/pages/layout/shell-navigation.test.ts` around lines 54 - 66,
The test's resolveProjectRoot mock is not actually exercised because
openNewSession() is called with no directory; change the test to call
shell.openNewSession with an explicit directory string (e.g. "/some/dir") so
createShellNavigation's resolveProjectRoot mock (resolveProjectRoot: () => "")
runs and returns the empty string, thereby exercising the explicit-directory +
empty-string fallback path and still asserting that chooseProject is invoked;
reference createShellNavigation, resolveProjectRoot, and openNewSession when
making this change.

packages/app/src/pages/session/session-main-view.tsx (1)

114-127: 💤 Low value

Consider using the Button component for consistency.

The retry and new session buttons use manual styling while the Button component is already imported and used elsewhere in the codebase. Using Button variant="ghost" would ensure consistent styling, focus states, and accessibility behavior across the app.

♻️ Suggested change

-                      <button
-                        type="button"
-                        class="rounded-md border border-border-subtle px-3 py-1 text-13-regular text-text-base transition-colors hover:bg-surface-raised-base-hover focus:outline-none focus-visible:bg-surface-raised-base-hover"
-                        onClick={props.onRetryOpenSession}
-                      >
-                        {props.language.t("common.retry")}
-                      </button>
-                      <button
-                        type="button"
-                        class="rounded-md border border-border-subtle px-3 py-1 text-13-regular text-text-base transition-colors hover:bg-surface-raised-base-hover focus:outline-none focus-visible:bg-surface-raised-base-hover"
-                        onClick={props.onOpenNewSession}
-                      >
-                        {props.language.t("command.session.new")}
-                      </button>
+                      <Button variant="ghost" size="small" onClick={props.onRetryOpenSession}>
+                        {props.language.t("common.retry")}
+                      </Button>
+                      <Button variant="ghost" size="small" onClick={props.onOpenNewSession}>
+                        {props.language.t("command.session.new")}
+                      </Button>

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/app/src/pages/session/session-main-view.tsx` around lines 114 - 127,
Replace the two plain <button> elements used for retry and new session with the
shared Button component to ensure consistent styling and accessibility: locate
the elements handling props.onRetryOpenSession and props.onOpenNewSession in
SessionMainView (session-main-view.tsx) and swap them to use Button with
variant="ghost" (or the matching ghost prop the project uses), forwarding the
onClick handlers to Button and keeping the children as
props.language.t("common.retry") and props.language.t("command.session.new");
ensure any class attributes are removed so the Button's built-in styles and
focus behavior are used.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes