fix: finalize cancelled shell runs#39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TERMand partial-output preservationWhy
After PR #36 merged, CI run #107 started failing in
prompt-effectcancellation coverage. Early shell cancellation could race ahead of the normal finalization path, which either threwImpossiblewhile looking up the last assistant message or reused a still-running bash tool snapshot. The fallback path also dropped already-streamed shell output.Related Issue
Follow-up to #36. Triggered by CI run #107 after merge.
How To Verify
Screenshots or Recordings
N/A, no visible UI changes.
Checklist
devbranch