packages/app/src/pages/session/session-todos.test.ts (1)

53-61: ⚡ Quick win

Add a fallback-backend precedence test case.

You validate fallback parts, but not the branch where fallback.backend is non-empty. Adding that assertion locks down the full selection order and protects this bugfix path from regressions.

Proposed test addition

 describe("selectSessionTodos", () => {
+  test("prefers fallback backend todos over fallback parts todos", () => {
+    const fallbackParts = [
+      toolPart("todowrite", completedState({ input: { todos: [todo("from fallback parts", "in_progress")] } })),
+    ]
+
+    expect(
+      selectSessionTodos({
+        backend: [],
+        parts: [],
+        fallback: {
+          backend: [todo("from fallback backend", "pending")],
+          parts: fallbackParts,
+        },
+      }),
+    ).toEqual([todo("from fallback backend", "pending")])
+  })
+
   test("falls back to a secondary session source when the primary source is empty", () => {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/app/src/pages/session/session-todos.test.ts` around lines 53 - 61,
Add a test variant to cover the fallback.backend precedence: the current test
only exercises fallback.parts, so create an additional assertion calling
selectSessionTodos with backend: [], parts: [], and fallback: { backend: [ /* a
backend todo source */ ], parts: [...] } and assert the returned todos come from
fallback.backend instead of fallback.parts; reference the existing helpers and
symbols (selectSessionTodos, toolPart, completedState, todo) to construct the
fallback.backend item so the test pins the correct selection order.

packages/app/src/pages/session/session-todos.ts (1)

13-16: ⚡ Quick win

Drop the as Todo[] casts to keep type drift visible.

These assertions hide future schema mismatches. Returning extractTodos(...) directly keeps compile-time checks honest without changing runtime behavior.

Type-safety cleanup

   const fromParts = extractTodos(input.parts)
-  if (fromParts.length > 0) return fromParts as Todo[]
+  if (fromParts.length > 0) return fromParts

   if (input.fallback?.backend && input.fallback.backend.length > 0) return input.fallback.backend
-  return extractTodos(input.fallback?.parts ?? []) as Todo[]
+  return extractTodos(input.fallback?.parts ?? [])

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/app/src/pages/session/session-todos.ts` around lines 13 - 16, The
code currently forces types with casts like "fromParts as Todo[]" and
"extractTodos(...) as Todo[]", which masks schema mismatches; remove the "as
Todo[]" assertions so functions/variables (fromParts, input.fallback.backend,
extractTodos, Todo) retain their inferred types and let the compiler surface
mismatches; update the return lines in session-todos.ts to return fromParts,
input.fallback.backend, and extractTodos(...) directly (no casts) and run
typecheck to fix any resulting type errors by adjusting upstream types or
signatures instead of reintroducing assertions.