fix: keep todo dock after manual stop#321
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 0/3 reviews remaining, refill in 12 minutes and 30 seconds. Comment |
There was a problem hiding this comment.
Code Review
This pull request modifies the session abortion logic to ensure that cached todos are preserved when a session is aborted. Specifically, it removes the code that previously cleared global and child todo sets within the abort function in submit.ts. Correspondingly, the test suite in submit.test.ts has been updated with new tracking variables and a test case to verify that these todos are no longer cleared during abortion. I have no feedback to provide.
Summary
Keep cached session todos intact when the user manually stops an active turn.
Why
Fixes the manual Stop path from #319. The Todo dock already stays mounted while todo data exists, but the abort handler was clearing the local todo cache before the backend had cleared the todo list.
Related Issue
Fixes #319.
How To Verify
Screenshots or Recordings
Not attached. The change preserves existing UI state and does not alter visible copy. The behavior is covered by a focused unit regression and the existing Todo dock E2E.
Checklist
dev, and my PR title and commit messages use Conventional Commits in English