Skip to content

fix: keep todo dock after manual stop#321

Merged
Astro-Han merged 1 commit into
devfrom
codex/fix-i319-todo-dock
Apr 29, 2026
Merged

fix: keep todo dock after manual stop#321
Astro-Han merged 1 commit into
devfrom
codex/fix-i319-todo-dock

Conversation

@Astro-Han

Copy link
Copy Markdown
Owner

Summary

Keep cached session todos intact when the user manually stops an active turn.

Why

Fixes the manual Stop path from #319. The Todo dock already stays mounted while todo data exists, but the abort handler was clearing the local todo cache before the backend had cleared the todo list.

Related Issue

Fixes #319.

How To Verify

bun install --frozen-lockfile
bun --cwd packages/app test:unit src/components/prompt-input/submit.test.ts
bun --cwd packages/app typecheck
git diff --check
bun --cwd packages/app playwright test e2e/session/session-composer-dock.spec.ts --grep "todo dock"

Screenshots or Recordings

Not attached. The change preserves existing UI state and does not alter visible copy. The behavior is covered by a focused unit regression and the existing Todo dock E2E.

Checklist

  • I linked the related issue, or stated why there is no issue
  • This PR has type, scope, and priority labels, or I requested maintainer labeling
  • I listed the relevant verification steps, including tests when behavior changed
  • I manually checked visible UI or copy changes when needed, with screenshots or recordings
  • I considered macOS and Windows impact for desktop, packaging, updater, signing, paths, shell, or permissions changes
  • I called out docs, release notes, dependencies, permissions, credentials, deletion behavior, or generated/local file changes when relevant
  • I am targeting dev, and my PR title and commit messages use Conventional Commits in English

@Astro-Han Astro-Han added bug Something isn't working P2 Medium priority app Application behavior and product flows labels Apr 29, 2026
@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@Astro-Han has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 12 minutes and 30 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fae7e7ad-9f20-4fef-babb-9c50ae02ff4b

📥 Commits

Reviewing files that changed from the base of the PR and between c2d75c2 and 9e25337.

📒 Files selected for processing (2)
  • packages/app/src/components/prompt-input/submit.test.ts
  • packages/app/src/components/prompt-input/submit.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-i319-todo-dock

Review rate limit: 0/3 reviews remaining, refill in 12 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the session abortion logic to ensure that cached todos are preserved when a session is aborted. Specifically, it removes the code that previously cleared global and child todo sets within the abort function in submit.ts. Correspondingly, the test suite in submit.test.ts has been updated with new tracking variables and a test case to verify that these todos are no longer cleared during abortion. I have no feedback to provide.

@Astro-Han Astro-Han merged commit d3a3e20 into dev Apr 29, 2026
25 checks passed
@Astro-Han Astro-Han deleted the codex/fix-i319-todo-dock branch April 29, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app Application behavior and product flows bug Something isn't working P2 Medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Manually stopping a turn clears the todo dock instead of keeping it mounted

1 participant