fix(app): ignore stale assistant messages for running state by Astro-Han · Pull Request #109 · Astro-Han/pawwork

Astro-Han · 2026-04-21T16:02:43Z

Summary

Add a shared isSessionRunning helper for app session running-state checks.
Treat live non-idle session_status as authoritative, and only fall back to message history when the latest message is an incomplete assistant message.
Replace the broad historical incomplete-assistant scans in the session timeline, sidebar item, and session busy helper.

Why

A stale incomplete assistant message from an older turn can remain in session history even after later turns complete. The previous UI checks treated any historical incomplete assistant message as current work, which kept completed sessions showing progress/spinners.

Related Issue

Fixes #95

How To Verify

cd packages/app && bun run test:unit src/pages/session/session-running-state.test.ts
cd packages/app && bun run test:unit
cd packages/app && bun run typecheck
bun turbo typecheck
bun turbo test:ci

Screenshots or Recordings

Not included. This is a state-derivation fix covered by unit tests, with no intentional visual design change.

Checklist

I ran the relevant verification steps
I tested visible changes manually when needed
I am targeting the dev branch

Summary by CodeRabbit

Refactor
- Consolidated session state determination logic into a centralized shared helper function, reducing code duplication and improving maintainability across multiple application components.
Tests
- Added comprehensive test coverage for session running state evaluation, including edge cases and various status conditions.

coderabbitai · 2026-04-21T16:02:51Z

Warning

Rate limit exceeded

@Astro-Han has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 47 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 14 minutes and 47 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 26181787-1b5b-4430-8d2a-4fd82b5ef69f

📥 Commits

Reviewing files that changed from the base of the PR and between de0bffb and 7b44979.

📒 Files selected for processing (2)

packages/app/src/pages/session/session-running-state.test.ts
packages/app/src/pages/session/session-running-state.ts

📝 Walkthrough

Walkthrough

This change consolidates session "running" state logic from three UI components into a single, tested helper function isSessionRunning. The helper correctly checks only the latest assistant message for incompleteness, resolving a bug where stale incomplete messages kept completed sessions marked as running.

Changes

Cohort / File(s)	Summary
Session Running State Helper `packages/app/src/pages/session/session-running-state.ts`, `packages/app/src/pages/session/session-running-state.test.ts`	New helper function `isSessionRunning` that determines session status by checking non-idle session status or the latest assistant message's incompleteness. Includes comprehensive test fixtures and five test cases covering stale incomplete messages, varied session statuses, and edge cases.
Component Refactoring `packages/app/src/pages/layout/sidebar-items.tsx`, `packages/app/src/pages/session.tsx`, `packages/app/src/pages/session/message-timeline.tsx`	Replaced inline session running logic with calls to `isSessionRunning`, removing redundant status and message inspection code across three files. All three components now delegate to the centralized helper.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 One stale message made sessions spin round and round,
But now we extract truth from the latest we've found,
isSessionRunning checks what matters today—
No phantom spinners dancing in yesterday's way! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: introducing a helper to ignore stale assistant messages when determining session running state, directly addressing the linked issue.
Description check	✅ Passed	The description includes all required sections: Summary, Why, Related Issue (`#95`), How To Verify with test commands, and a completed Checklist confirming verification was performed.
Linked Issues check	✅ Passed	The pull request introduces the isSessionRunning helper and refactors three components to use it, treating non-idle session_status as authoritative and only checking incomplete assistant messages when idle. This directly implements the fix for issue `#95`.
Out of Scope Changes check	✅ Passed	All changes are directly in scope: new isSessionRunning helper with tests, and refactoring three existing components to use it. No unrelated modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/fix-session-running-state

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request centralizes the logic for determining if a session is active by introducing a new utility function, isSessionRunning, and applying it across several components including the sidebar, session page, and message timeline. Comprehensive unit tests were also added for this new utility. Feedback was provided regarding potential TypeScript errors when accessing message completion times, suggesting the use of optional chaining for better type safety.

Astro-Han

总体逻辑正确，测试覆盖充分。几点 inline 供参考（无阻塞问题）。

Astro-Han

Overall: Clean fix with good test coverage. One edge case suggestion.

Core Logic Review

The new isSessionRunning helper consolidates duplicate logic across 3 files — good refactor. The logic is:

if ((status ?? idle).type !== "idle") return true
const latest = messages?.at(-1)
return latest?.role === "assistant" && typeof latest.time?.completed !== "number"

Key insight: Trust live session_status over message history. Only fallback to checking the latest message, not scanning all history. This correctly fixes the stale-incomplete-assistant bug.

Edge Case: Empty Message Array

When messages is an empty array []:

messages?.at(-1) returns undefined
undefined?.role === "assistant" is false
Returns false ✓ (idle state)

This is correct behavior, but worth adding a test case for clarity.

Minor Nits

Test file import path: import { isSessionRunning } from "./session-running-state" — works, but explicit extension would be clearer for future tooling.
Test helper naming: The user and assistant factory functions are minimal. Consider adding JSDoc or renaming to makeUserMessage/makeAssistantMessage for discoverability.

These are nits; not blocking.

Suggestion: Add Empty Array Test

test("returns false when messages array is empty", () => {
  expect(isSessionRunning(idle, [])).toBe(false)
})

This documents the edge case and ensures future refactorers don't accidentally change behavior.

Astro-Han · 2026-04-22T01:37:33Z

@coderabbitai review

coderabbitai · 2026-04-22T01:37:37Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/app/src/pages/session/session-running-state.test.ts`:
- Around line 64-70: Add explicit tests calling isSessionRunning with undefined
inputs to lock the helper contract: add assertions in
session-running-state.test.ts that isSessionRunning(undefined, undefined)
returns false, isSessionRunning(undefined, []) returns false, and
isSessionRunning(undefined, [user("msg_user",1)]) behaves like the idle-case
expectation; reference the isSessionRunning helper to implement these new test
cases so callers passing undefined status or messages are covered.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2c11aa1a-f426-497b-b23d-51c709408429

📥 Commits

Reviewing files that changed from the base of the PR and between 63a8a52 and de0bffb.

📒 Files selected for processing (5)

packages/app/src/pages/layout/sidebar-items.tsx
packages/app/src/pages/session.tsx
packages/app/src/pages/session/message-timeline.tsx
packages/app/src/pages/session/session-running-state.test.ts
packages/app/src/pages/session/session-running-state.ts

fix(app): add session running state helper

762bf8d

Astro-Han added bug Something isn't working P2 Medium priority app Application behavior and product flows labels Apr 21, 2026

gemini-code-assist Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread packages/app/src/pages/session/session-running-state.ts Outdated

fix(app): ignore stale assistant messages for running state

8ca5931

Astro-Han force-pushed the codex/fix-session-running-state branch from 8faf1bb to 8ca5931 Compare April 21, 2026 16:21

Astro-Han commented Apr 21, 2026

View reviewed changes

coderabbitai Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread packages/app/src/pages/session/session-running-state.test.ts

test(app): cover empty session running state

7b44979

Astro-Han force-pushed the codex/fix-session-running-state branch from de0bffb to 7b44979 Compare April 22, 2026 02:17

Astro-Han merged commit 718e1c9 into dev Apr 22, 2026
14 checks passed

Astro-Han deleted the codex/fix-session-running-state branch April 22, 2026 02:23

Astro-Han mentioned this pull request Apr 22, 2026

[Bug] Update notice shows raw release download link #124

Closed

coderabbitai Bot mentioned this pull request Apr 27, 2026

fix: expire stale session running state #262

Merged

7 tasks

Conversation

Astro-Han commented Apr 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Related Issue

How To Verify

Screenshots or Recordings

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Astro-Han left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Astro-Han left a comment

Choose a reason for hiding this comment

Core Logic Review

Edge Case: Empty Message Array

Minor Nits

Suggestion: Add Empty Array Test

Uh oh!

Astro-Han commented Apr 22, 2026

Uh oh!

coderabbitai Bot commented Apr 22, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Astro-Han commented Apr 21, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 21, 2026 •

edited

Loading