test(windows): unblock primary-mode allowlist match and skip POSIX-only ci-smoke

Astro-Han · Astro-Han · commit 8ac15c454ba0 · 2026-05-04T15:39:43.000+08:00
Two unrelated test fixtures that both keep the windows-advisory advisory red: - `packages/app/src/no-mode-picker.test.ts`: the allowlist stores entries with POSIX-style paths but `path.relative` returns backslashes on Windows, so the allowlist never matched and the legitimate `context/global-sync/utils.ts` reference flagged as an offender. Normalize `relPath` to forward slashes before comparing, mirroring the same fix applied earlier to `agent-rename.test.ts`. - `packages/desktop-electron/scripts/ci-smoke.test.ts`: the "packaged smoke reports spawn failures with launch context" fixture relies on an empty file + chmod 0o755 to hit ENOEXEC and exercise the `Failed to launch desktop app:` branch. Windows has no equivalent (empty files via cmd exit cleanly through a different branch), and the assertion targets the spawn error format rather than Windows-specific launch semantics. Gate the test with `test.skipIf(process.platform === "win32")`. Refs #426
diff --git a/packages/app/src/no-mode-picker.test.ts b/packages/app/src/no-mode-picker.test.ts
@@ -48,7 +48,10 @@ test('no source file in packages/app/src uses mode === "primary" outside the all
     const lines = text.split(/\r?\n/)
     lines.forEach((lineText, i) => {
       if (!re.test(lineText)) return
-      const relPath = path.relative(APP_SRC, file)
+      // Normalize to forward slashes so the Windows backslash form of
+      // `path.relative` still matches MODE_PRIMARY_ALLOWLIST entries authored
+      // with POSIX-style paths.
+      const relPath = path.relative(APP_SRC, file).replaceAll(path.sep, "/")
       const ok = MODE_PRIMARY_ALLOWLIST.some((a) => a.file === relPath && a.line === i + 1)
       if (!ok) offenders.push({ file: relPath, line: i + 1, text: lineText.trim() })
     })
diff --git a/packages/desktop-electron/scripts/ci-smoke.test.ts b/packages/desktop-electron/scripts/ci-smoke.test.ts
@@ -114,27 +114,36 @@ describe("ci smoke helpers", () => {
     })
   })
 
-  test("packaged smoke reports spawn failures with launch context", () => {
-    const dir = mkdtempSync(path.join(tmpdir(), "pawwork-ci-smoke-"))
-    try {
-      const executablePath = path.join(dir, "PawWork")
-      writeFileSync(executablePath, "")
-      chmodSync(executablePath, 0o755)
-
-      const result = spawnSync(
-        process.execPath,
-        [path.join(import.meta.dir, "ci-smoke.ts"), "packaged", "dev", executablePath],
-        {
-          encoding: "utf8",
-          timeout: 5_000,
-        },
-      )
-
-      expect(result.status).not.toBe(0)
-      expect(`${result.stdout}${result.stderr}`).toContain("Failed to launch desktop app:")
-      expect(`${result.stdout}${result.stderr}`).toContain(executablePath)
-    } finally {
-      rmSync(dir, { recursive: true, force: true })
-    }
-  })
+  // POSIX-only: the fixture relies on creating an empty file with chmod 0o755
+  // to trigger an ENOEXEC spawn error so ci-smoke.ts emits the
+  // "Failed to launch desktop app:" branch. Windows has no direct equivalent
+  // (empty files run through cmd exit cleanly, sending the flow through the
+  // "Electron exited" branch instead), and the assertion targets the spawn
+  // error format itself, not Windows-specific launch behavior.
+  test.skipIf(process.platform === "win32")(
+    "packaged smoke reports spawn failures with launch context",
+    () => {
+      const dir = mkdtempSync(path.join(tmpdir(), "pawwork-ci-smoke-"))
+      try {
+        const executablePath = path.join(dir, "PawWork")
+        writeFileSync(executablePath, "")
+        chmodSync(executablePath, 0o755)
+
+        const result = spawnSync(
+          process.execPath,
+          [path.join(import.meta.dir, "ci-smoke.ts"), "packaged", "dev", executablePath],
+          {
+            encoding: "utf8",
+            timeout: 5_000,
+          },
+        )
+
+        expect(result.status).not.toBe(0)
+        expect(`${result.stdout}${result.stderr}`).toContain("Failed to launch desktop app:")
+        expect(`${result.stdout}${result.stderr}`).toContain(executablePath)
+      } finally {
+        rmSync(dir, { recursive: true, force: true })
+      }
+    },
+  )
 })
