fix: XCM handshake version negotiation#1578
Merged
ipapandinas merged 3 commits intomasterfrom Jan 26, 2026
Merged
Conversation
Dinonard
reviewed
Jan 12, 2026
Contributor
Dinonard
left a comment
There was a problem hiding this comment.
LGTM
Glad it's not some deeper issue.
Dinonard
previously approved these changes
Jan 13, 2026
Added licensing information and test requirements for XCM version negotiation.
Minimum allowed line rate is |
Dinonard
approved these changes
Jan 19, 2026
PierreOssun
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Closes #1523
This PR updates the
XcmBarrierto wrap it withTrailingSetTopicAsId(using SetTopic instruction value as message ID instead of XCM Crosschain Index) and includesWithComputedOriginaroundAllowSubscriptionsFromto properly recontextualize sibling parachain origins.XCM simulator mocks are adjusted accordingly and version tests are added.