Merged
Conversation
Dinonard
previously approved these changes
Dec 5, 2025
Contributor
Dinonard
left a comment
There was a problem hiding this comment.
LGTM
@PierreOssun please take a look as well.
PierreOssun
reviewed
Dec 9, 2025
| // register relay asset in ParaB | ||
| ParaB::execute_with(|| { | ||
| // Register relay asset in ParaC (Asset Hub) | ||
| ParaC::execute_with(|| { |
Contributor
There was a problem hiding this comment.
As ParaC is only used as AssetHub mock (id = 1000) maybe rename it to ParaAssetHub (like we had Relay ? So no need for all descriptive comments
Contributor
Author
There was a problem hiding this comment.
Good idea, I've renamed it and cleanup some comments
Minimum allowed line rate is |
Dinonard
approved these changes
Dec 15, 2025
PierreOssun
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Closes #1559
This PR also adjusts XCM simulator tests to use ParaC (Asset Hub) as reserver for relay tokens.