Merged
Conversation
Dinonard
previously approved these changes
Dec 4, 2025
.github/workflows/release-client.yml
Outdated
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| gh release create "$RELEASE_TAG" \ | ||
| --target "$GITHUB_SHA" \ |
Contributor
There was a problem hiding this comment.
This part seems redundant if you've already specified the tag.
Perhaps --verify-tag would be more appropriate.
Contributor
Author
There was a problem hiding this comment.
Yes maybe the target is redundant, I can remove it. I am not using --verify-tag to support manually triggered workflows that use the branch name
Minimum allowed line rate is |
Dinonard
approved these changes
Dec 5, 2025
ashutoshvarma
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Closes #1526
This PR replaces outdated actions
create-release@v1andupload-release-asset@v1with the Github CLI gh preinstalled on each workflows.