You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates the collator selection mechanism to governance approved system. A candidate applicant needs to apply first by reserving the bond and only once application is approved by governanace the node is added to collator candidates. Also governanace can kick & slash bad performing collator candidates.
The pallet uses two configurable origins for governance actions
GovernanceOrigin: Can approve/close candidacy applications
ForceRemovalOrigin: Can forcibly kick and slash candidates
The following extrinsincs are added,
apply_for_candidacy: Apply to be a candidate by reserving bond
close_application: Close pending candidate application, unreserve the bond.
approve_application: Approve the candidate application, add node to candidates. (Only GovernanceOrigin)
kick_candidate: Kick and slash a candidate immediately. (Only ForceRemovalOrigin)
If governance wish to remove a candidate without slashing, it can be done via wrapping the leave_intent call with utility's dispatch_as via a referendum
Note:-
The old register_as_candidate is deprecated and will fail with Permission error (should be removed?)
Configs
For Astar & Shibuya
GovernanceOrigin: 2/3 MainCouncil OR Referendum
ForceRemovalOrigin: 2/3 MainCouncil OR Referendum
For Shiden, both root account
TODO
Finalise the origins config for Astar
Astar Docs PR
Check list**
added or updated unit tests
updated Astar official documentation
added benchmarks & weights for any modified runtime logics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtimeThis PR/Issue is related to the topic “runtime”.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves #1521
Summary
This PR updates the collator selection mechanism to governance approved system. A candidate applicant needs to apply first by reserving the bond and only once application is approved by governanace the node is added to collator candidates. Also governanace can kick & slash bad performing collator candidates.
The pallet uses two configurable origins for governance actions
GovernanceOrigin: Can approve/close candidacy applicationsForceRemovalOrigin: Can forcibly kick and slash candidatesThe following extrinsincs are added,
apply_for_candidacy: Apply to be a candidate by reserving bondclose_application: Close pending candidate application, unreserve the bond.approve_application: Approve the candidate application, add node to candidates. (OnlyGovernanceOrigin)kick_candidate: Kick and slash a candidate immediately. (OnlyForceRemovalOrigin)leave_intentcall with utility'sdispatch_asvia a referendumNote:-
The old
register_as_candidateis deprecated and will fail withPermissionerror (should be removed?)Configs
For Astar & Shibuya
GovernanceOrigin: 2/3 MainCouncil OR ReferendumForceRemovalOrigin: 2/3 MainCouncil OR ReferendumFor Shiden, both root account
TODO
Check list**