Conversation
ermalkaleci
reviewed
Jul 21, 2025
|
|
||
| # TODO: Should be moved below the `rustup show` once the toolchain | ||
| - name: Install frame-omni bencher tool | ||
| run: cargo install --git https://github.com/paritytech/polkadot-sdk frame-omni-bencher --profile=production --locked |
Contributor
There was a problem hiding this comment.
can't we do cargo +nightly?
Contributor
Author
There was a problem hiding this comment.
I can specify the toolchain, but I still have to install it.
Don't know what's avaialble on our custom machine in advance (and it can change).
ermalkaleci
previously approved these changes
Jul 21, 2025
ipapandinas
approved these changes
Jul 21, 2025
ermalkaleci
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Another attempt to fix the omni-bencher build process.
This has been tested on github runner, but remains to be seen if it will work on our custom runner.