TxPause&SafeMode for Astar by Dinonard · Pull Request #1501 · AstarNetwork/Astar

Dinonard · 2025-07-16T13:23:03Z

Pull Request Summary

Introduces safe mode & tx pause support for Astar.

ashutoshvarma

looks good!
Do we want to add integration tests for it?

runtime/astar/src/lib.rs

ipapandinas

LGTM, thanks for opening issue #1503

ashutoshvarma

LGTM

ermalkaleci · 2025-07-21T07:52:41Z

runtime/astar/src/lib.rs

+            | RuntimeCall::TechnicalCommittee(_)
+            | RuntimeCall::Sudo(_)
+            | RuntimeCall::Democracy(
+                pallet_democracy::Call::external_propose_majority { .. }


don't we need vote?

I've thought about that but decided to exclude it since it's not a privileged action.

In a recent exploit scenario, the problematic account could have voted to put funds into locked state, which would be problematic for us. This is why it's blocked.

Rest of the whitelisted calls are all privileged ones, that require collective agreement.

@ermalkaleci I've allowed Vote and added a comprehensive integration test to demonstrate the full flow of how recovery would go.

@Dinonard we may want to allow proxy as well

@Dinonard do we need to allow oracle?

Preimage as well

For preimage, sure, makes sense if we want to run referendum.
Multisig can also be alloed, since the embedded calls will be filtered again.

For oracle, I'm not sure.
We can allow them, but keep the option to block those calls using tx-pause I guess.

EDIT: added, thanks for the suggestion

…ause-astar

Dinonard · 2025-07-22T06:46:37Z

/bench astar

github-actions · 2025-07-22T07:30:58Z

Benchmark job failed.
Please check https://github.com/AstarNetwork/Astar/actions/runs/16436860112.

Dinonard · 2025-07-22T07:32:40Z

/bench astar pallet_inflation

github-actions · 2025-07-22T08:13:43Z

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/16437771685.
Please wait for a while.
Branch: feat/safe-mode-tx-pause-astar
SHA: efd96e1

github-actions · 2025-07-22T08:34:04Z

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/16437771685.

PierreOssun

LGTM

ipapandinas · 2025-07-22T13:22:21Z

runtime/astar/src/lib.rs

+                | b"Council"
+                | b"TechnicalCommittee"
+                | b"Sudo"
+                | b"TxPause"


Same for the tx-pause pallet, its own calls are always allowed.

https://github.com/paritytech/polkadot-sdk/blob/2f8d2a2b875a3f08aae5dd82c09ffe65932d2e62/substrate/frame/tx-pause/src/lib.rs#L257-L260

I know, but wanted to add it here for completeness, irrelevant of the implementation details.

I could remove it.

Thanks for the explanation, I don't have a strong opinion, we can keep it

ipapandinas · 2025-07-22T13:22:23Z

runtime/astar/src/lib.rs

+            )
+            | RuntimeCall::Proxy(_)
+            | RuntimeCall::TxPause(_)
+            | RuntimeCall::SafeMode(_) => true,


The safe-mode pallet always allows its own calls.

https://github.com/paritytech/polkadot-sdk/blob/2f8d2a2b875a3f08aae5dd82c09ffe65932d2e62/substrate/frame/safe-mode/src/lib.rs#L591-L594

ipapandinas · 2025-07-22T13:27:33Z

tests/integration/src/governance.rs

+
+        // Now use main council to extend safe mode
+        let safe_mode_extend_call = RuntimeCall::SafeMode(pallet_safe_mode::Call::force_extend {});
+        propose_vote_and_close!(Council, safe_mode_extend_call, 0);


Do we want to check the correct extension against the configuration param? This can be done by reading enteredUntil storage value.

I want to avoid checking pallet's implementation details.
If duration doesn't properly work, it's not something for integration tests to discover IMO.

tests/integration/src/governance.rs

ipapandinas · 2025-07-22T13:49:24Z

runtime/astar/src/lib.rs

+    type RuntimeCall = RuntimeCall;
+    type PauseOrigin = EnsureRootOrHalfTechCommitteeOrTwoThirdCouncil;
+    type UnpauseOrigin = EnsureRootOrHalfTechCommitteeOrTwoThirdCouncil;
+    type WhitelistedCalls = TxPauseWhitelistedCalls;


When I've added tx_pause into Shibuya, I didn't specified whitelisting on purpose, reference: #1388 (comment)

In fact, I've just removed the TxPauseWhitelistedCalls type and its Contains trait implementation. tx-pause is more granular, we should be able to pause any call in an emergency.

But I guess you're adding it now on purpose to avoid being stuck?

I haven't checked this, but thanks for the reminder.

I've added it since Pierre commented it, and avoiding being stuck just came as an extra reason later.

ipapandinas

LGTM

Dinonard · 2025-07-25T07:48:01Z

@ermalkaleci @ashutoshvarma can you please also check & think about more possible problematic scenarios?

github-actions · 2025-07-28T09:13:56Z

Package	Line Rate	Branch Rate	Health
pallets/dapp-staking/src/benchmarking	95%	0%	✔
pallets/dapp-staking/src/test	0%	0%	❌
pallets/vesting-mbm/src	87%	0%	✔
primitives/src	54%	0%	➖
pallets/unified-accounts/src	79%	0%	➖
precompiles/dapp-staking/src	89%	0%	✔
pallets/astar-xcm-benchmarks/src	86%	0%	✔
precompiles/dispatch-lockdrop/src	83%	0%	✔
precompiles/sr25519/src	56%	0%	➖
chain-extensions/unified-accounts/src	0%	0%	❌
precompiles/unified-accounts/src	100%	0%	✔
pallets/static-price-provider/src	91%	0%	✔
pallets/xc-asset-config/src	62%	0%	➖
pallets/astar-xcm-benchmarks/src/fungible	100%	0%	✔
precompiles/xcm/src	69%	0%	➖
chain-extensions/types/unified-accounts/src	0%	0%	❌
pallets/ethereum-checked/src	76%	0%	➖
chain-extensions/types/assets/src	0%	0%	❌
pallets/dapp-staking/src	80%	0%	✔
precompiles/dapp-staking/src/test	0%	0%	❌
pallets/dynamic-evm-base-fee/src	85%	0%	✔
pallets/astar-xcm-benchmarks/src/generic	100%	0%	✔
pallets/inflation/src	84%	0%	✔
precompiles/substrate-ecdsa/src	67%	0%	➖
pallets/collator-selection/src	89%	0%	✔
primitives/src/xcm	64%	0%	➖
pallets/price-aggregator/src	75%	0%	➖
pallets/collective-proxy/src	94%	0%	✔
pallets/dapp-staking/rpc/runtime-api/src	0%	0%	❌
pallets/democracy-mbm/src	30%	0%	❌
chain-extensions/pallet-assets/src	54%	0%	➖
precompiles/assets-erc20/src	77%	0%	➖
Summary	74% (3791 / 5116)	0% (0 / 0)	➖

Minimum allowed line rate is 50%

ermalkaleci

LGTM

Dinonard · 2025-07-28T12:25:33Z

Merging it since I got approval from everyone, at least once 🙂

TxPause&SafeMode for Astar

bf7e656

Dinonard added the runtime This PR/Issue is related to the topic “runtime”. label Jul 16, 2025

Dinonard marked this pull request as ready for review July 17, 2025 07:01

Dinonard requested review from PierreOssun, ashutoshvarma and ipapandinas July 17, 2025 07:01

ashutoshvarma reviewed Jul 17, 2025

View reviewed changes

PierreOssun reviewed Jul 17, 2025

View reviewed changes

runtime/astar/src/lib.rs Outdated Show resolved Hide resolved

ipapandinas previously approved these changes Jul 17, 2025

View reviewed changes

Review adjustment

ffcd086

Dinonard dismissed ipapandinas’s stale review via ffcd086 July 17, 2025 13:45

Expand whitelist, more tests

e543595

ashutoshvarma previously approved these changes Jul 18, 2025

View reviewed changes

Dinonard requested review from PierreOssun, ermalkaleci and ipapandinas July 18, 2025 09:25

ermalkaleci reviewed Jul 21, 2025

View reviewed changes

Updated filter & more tests

3235653

Dinonard dismissed ashutoshvarma’s stale review via 3235653 July 22, 2025 05:51

Dinonard added 4 commits July 22, 2025 07:53

Exit safe mode

2fefdc3

Merge remote-tracking branch 'origin/master' into feat/safe-mode-tx-p…

592c15b

…ause-astar

Resolve TODOs

ccb4873

Update benchmark script

efd96e1

Proxy, weight updates

60ded85

PierreOssun previously approved these changes Jul 22, 2025

View reviewed changes

ipapandinas reviewed Jul 22, 2025

View reviewed changes

ipapandinas previously approved these changes Jul 22, 2025

View reviewed changes

Review comments

3896ab0

Dinonard dismissed stale reviews from ipapandinas and PierreOssun via 3896ab0 July 28, 2025 08:13

utility update

7ee8a7d

ermalkaleci approved these changes Jul 28, 2025

View reviewed changes

ipapandinas approved these changes Jul 28, 2025

View reviewed changes

Dinonard merged commit 85bb686 into master Jul 28, 2025
7 of 8 checks passed

Dinonard deleted the feat/safe-mode-tx-pause-astar branch July 28, 2025 12:25

Conversation

Dinonard commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashutoshvarma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ipapandinas left a comment

Choose a reason for hiding this comment

Uh oh!

ashutoshvarma left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dinonard Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dinonard commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

Dinonard commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

PierreOssun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ipapandinas Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ipapandinas left a comment

Choose a reason for hiding this comment

Uh oh!

Dinonard commented Jul 25, 2025

Uh oh!

github-actions bot commented Jul 28, 2025

Uh oh!

ermalkaleci left a comment

Choose a reason for hiding this comment

Uh oh!

Dinonard commented Jul 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Dinonard commented Jul 16, 2025 •

edited

Loading

Dinonard Jul 28, 2025 •

edited

Loading

ipapandinas Jul 22, 2025 •

edited

Loading