TryState checks workflow run on production runtimes#1499
TryState checks workflow run on production runtimes#1499ipapandinas merged 21 commits intomasterfrom
Conversation
There was a problem hiding this comment.
The checkout needs to happen before rust show to install correct version.
And all this script can be replaced with
curl -s -L 'https://rpc.astar.network' \
--header 'Content-Type: application/json' \
--data '{
"jsonrpc": "2.0",
"method": "state_getRuntimeVersion",
"params": [],
"id": 1
}' | jq .result.specVersion
|
|
@ermalkaleci I am using websocat instead of curl because the endpoints are WebSockets |
|
It is http as well |
| - name: Checkout sources | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
I believe Ermal pointed this part as redundant, right?
There was a problem hiding this comment.
No, I mean the other git checkout is redundant. I will add more comments
There was a problem hiding this comment.
Ehmmm ok.
Not sure how the other one can be redundant though since it's done after finding the tag.
| run: sudo apt -y install protobuf-compiler | ||
| run: | | ||
| sudo apt -y install protobuf-compiler jq | ||
| curl -L https://github.com/vi/websocat/releases/latest/download/websocat.x86_64-unknown-linux-musl -o websocat |
There was a problem hiding this comment.
You mentioned it doesn't work for the secret WSS endpoint, but do you need to use that one?
In case of e.g. try-runtime tests we want to use something without limits.
But for a single RPC request, public endpoint should be just fine, right?
There was a problem hiding this comment.
You're right, I hadn't considered this approach, but it makes much more sense
| @@ -24,17 +24,47 @@ jobs: | |||
| steps: | |||
There was a problem hiding this comment.
First extend matrix with
runtime:
- { name: astar, endpoint: ASTAR_RUNTIME_ENDPOINT, http: 'https://rpc.astar.network' }
- { name: shiden, endpoint: SHIDEN_RUNTIME_ENDPOINT, http: 'https://rpc.shiden.astar.network' }
- { name: shibuya, endpoint: SHIBUYA_RUNTIME_ENDPOINT, http: 'https://rpc.shibuya.astar.network' }
and a step before checkout to find the tag:
| steps: | |
| steps: | |
| - run: | | |
| SPEC_VERSION=$(curl -s https://rpc.astar.network -H 'Content-Type: application/json' -d'{"jsonrpc":"2.0","method":"state_getRuntimeVersion","params":[],"id":1}' | jq -r .result.specVersion) | |
| echo "RUNTIME_TAG=runtime-$SPEC_VERSION" >> $GITHUB_ENV |
finally checkout at ref:
uses: actions/checkout@v4
with:
ref: ${{ env.RUNTIME_TAG }}
fetch-depth: 0
There was a problem hiding this comment.
Thanks for the additional guidance, it helped a lot. I now understand what was wrong and what you had in mind. I've pushed the updates, so hopefully everything is correct now
Minimum allowed line rate is |
Pull Request Summary
Complete #1498 to run
try-statechecks workflow on production runtimes.