Skip to content

chore: Invariant checks added for EraInfo#1489

Merged
ipapandinas merged 5 commits intomasterfrom
chore/era-info-try-state
Jun 23, 2025
Merged

chore: Invariant checks added for EraInfo#1489
ipapandinas merged 5 commits intomasterfrom
chore/era-info-try-state

Conversation

@ipapandinas
Copy link
Contributor

@ipapandinas ipapandinas commented Jun 19, 2025

Pull Request Summary

Add try_state_era_info invariant checks to prevent inflated next-era voting stake totals in CurrentEraInfo, following bug discovery and fix in #1476.

Check list

  • added or updated unit tests

Follow-up task

@ipapandinas ipapandinas added the tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc. label Jun 19, 2025
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/vesting-mbm/src 87% 0%
pallets/inflation/src 84% 0%
precompiles/assets-erc20/src 77% 0%
precompiles/xcm/src 69% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/dapp-staking/src/test 0% 0%
pallets/xc-asset-config/src 62% 0%
primitives/src/xcm 62% 0%
precompiles/substrate-ecdsa/src 67% 0%
pallets/collective-proxy/src 94% 0%
pallets/dapp-staking/src/benchmarking 95% 0%
precompiles/sr25519/src 56% 0%
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
precompiles/dapp-staking/src/test 0% 0%
chain-extensions/pallet-assets/src 54% 0%
precompiles/dispatch-lockdrop/src 83% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
pallets/ethereum-checked/src 76% 0%
pallets/dynamic-evm-base-fee/src 85% 0%
pallets/collator-selection/src 86% 0%
precompiles/unified-accounts/src 100% 0%
chain-extensions/types/unified-accounts/src 0% 0%
precompiles/dapp-staking/src 89% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/democracy-mbm/src 30% 0%
pallets/dapp-staking/src 80% 0%
pallets/unified-accounts/src 80% 0%
primitives/src 54% 0%
pallets/price-aggregator/src 75% 0%
chain-extensions/types/assets/src 0% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/static-price-provider/src 91% 0%
Summary 74% (3751 / 5079) 0% (0 / 0)

Minimum allowed line rate is 50%

@ipapandinas ipapandinas merged commit e531542 into master Jun 23, 2025
8 checks passed
@ipapandinas ipapandinas deleted the chore/era-info-try-state branch June 23, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dapps-staking Dapps Staking tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants