Skip to content

Frame Omni Bencher integration#1319

Merged
Dinonard merged 8 commits intomasterfrom
feat/frame-omni-bencher-integration
Jul 21, 2025
Merged

Frame Omni Bencher integration#1319
Dinonard merged 8 commits intomasterfrom
feat/frame-omni-bencher-integration

Conversation

@Dinonard
Copy link
Contributor

@Dinonard Dinonard commented Aug 9, 2024

Pull Request Summary

Modified the benchmark CI by replacing building the entire client, with only building runtime blobs.
Instead of using client to run the benchmarks, the new Frame Omni Bencher tools is used.

@Dinonard Dinonard added ci This PR/Issue is related to the topic "CI" other PR/issue is related to third-party, scripts or other things which don't have definite label. labels Aug 9, 2024
@Dinonard Dinonard linked an issue Aug 9, 2024 that may be closed by this pull request
[CI] Integrate Runtime Omni Bencher #1316
Closed
2 tasks
@Dinonard
Copy link
Contributor Author

Dinonard commented Aug 9, 2024

/bench astar,shibuya,shiden all

@github-actions
Copy link

github-actions bot commented Aug 9, 2024

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10314144768.
Please wait for a while.
Branch: feat/frame-omni-bencher-integration
SHA: cdcfd71

@github-actions
Copy link

github-actions bot commented Aug 9, 2024

Benchmark job failed.
Please check https://github.com/AstarNetwork/Astar/actions/runs/10314144768.

@github-actions
Copy link

github-actions bot commented Aug 9, 2024

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10314146522.
Please wait for a while.
Branch: feat/frame-omni-bencher-integration
SHA: cdcfd71

@github-actions
Copy link

github-actions bot commented Aug 9, 2024

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/10314146522.

@Dinonard Dinonard mentioned this pull request Sep 11, 2024
Merged
3 tasks
@github-actions
Copy link

github-actions bot commented Oct 9, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 9, 2024
@github-actions
Copy link

github-actions bot commented Oct 23, 2024

This PR was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this Oct 23, 2024
@Dinonard Dinonard reopened this Oct 23, 2024
@Dinonard Dinonard added project Issue is part of an ongoing project and removed Stale labels Oct 23, 2024
@github-actions
Copy link

github-actions bot commented Dec 23, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 23, 2024
@github-actions
Copy link

github-actions bot commented Jan 6, 2025

This PR was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this Jan 6, 2025
@Dinonard Dinonard removed the Stale label Jan 6, 2025
@Dinonard Dinonard reopened this Jan 6, 2025
@github-actions
Copy link

github-actions bot commented Mar 8, 2025

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 8, 2025
@github-actions
Copy link

github-actions bot commented Mar 22, 2025

This PR was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this Mar 22, 2025
@Dinonard Dinonard reopened this Mar 25, 2025
@Dinonard Dinonard removed the Stale label Mar 25, 2025
@github-actions
Copy link

github-actions bot commented May 25, 2025

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 25, 2025
@Dinonard Dinonard removed the Stale label May 26, 2025
@Dinonard
Copy link
Contributor Author

Dinonard commented Jul 21, 2025

/bench astar,shibuya,shiden all

@github-actions
Copy link

github-actions bot commented Jul 21, 2025

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/16411067265.
Please wait for a while.
Branch: feat/frame-omni-bencher-integration
SHA: 937c657

@github-actions
Copy link

github-actions bot commented Jul 21, 2025

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/16411067265.

@Dinonard Dinonard marked this pull request as ready for review July 21, 2025 08:29
@github-actions
Copy link

github-actions bot commented Jul 21, 2025

Code Coverage

Package Line Rate Branch Rate Health
pallets/inflation/src 84% 0% ✔
pallets/dynamic-evm-base-fee/src 82% 0% ✔
pallets/static-price-provider/src 91% 0% ✔
pallets/unified-accounts/src 80% 0% ✔
pallets/astar-xcm-benchmarks/src 86% 0% ✔
precompiles/dapp-staking/src/test 0% 0% ❌
pallets/collator-selection/src 89% 0% ✔
chain-extensions/types/unified-accounts/src 0% 0% ❌
precompiles/assets-erc20/src 77% 0% ➖
precompiles/sr25519/src 56% 0% ➖
pallets/dapp-staking/src/test 0% 0% ❌
precompiles/unified-accounts/src 100% 0% ✔
pallets/price-aggregator/src 75% 0% ➖
precompiles/xcm/src 69% 0% ➖
precompiles/dapp-staking/src 89% 0% ✔
pallets/democracy-mbm/src 30% 0% ❌
pallets/astar-xcm-benchmarks/src/fungible 100% 0% ✔
pallets/dapp-staking/src/benchmarking 95% 0% ✔
pallets/dapp-staking/src 80% 0% ✔
pallets/collective-proxy/src 94% 0% ✔
pallets/dapp-staking/rpc/runtime-api/src 0% 0% ❌
primitives/src 54% 0% ➖
primitives/src/xcm 64% 0% ➖
pallets/vesting-mbm/src 87% 0% ✔
precompiles/dispatch-lockdrop/src 83% 0% ✔
chain-extensions/unified-accounts/src 0% 0% ❌
pallets/astar-xcm-benchmarks/src/generic 100% 0% ✔
pallets/xc-asset-config/src 62% 0% ➖
pallets/ethereum-checked/src 76% 0% ➖
precompiles/substrate-ecdsa/src 67% 0% ➖
chain-extensions/types/assets/src 0% 0% ❌
chain-extensions/pallet-assets/src 54% 0% ➖
Summary 74% (3787 / 5116) 0% (0 / 0) ➖

Minimum allowed line rate is 50%

ermalkaleci
ermalkaleci previously approved these changes Jul 21, 2025
View reviewed changes
@Dinonard
Copy link
Contributor Author

Dinonard commented Jul 21, 2025

/bench astar,shibuya,shiden all

@github-actions
Copy link

github-actions bot commented Jul 21, 2025

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/16412992389.
Please wait for a while.
Branch: feat/frame-omni-bencher-integration
SHA: de6e729

@github-actions
Copy link

github-actions bot commented Jul 21, 2025

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/16412992389.

@Dinonard
Revert "Temp"
f1308e2 
This reverts commit de6e729.
@Dinonard Dinonard merged commit 18465c1 into master Jul 21, 2025
2 of 8 checks passed
@Dinonard Dinonard deleted the feat/frame-omni-bencher-integration branch July 21, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ermalkaleci ermalkaleci ermalkaleci approved these changes

@ipapandinas ipapandinas ipapandinas approved these changes

@ashutoshvarma ashutoshvarma Awaiting requested review from ashutoshvarma

@PierreOssun PierreOssun Awaiting requested review from PierreOssun

Assignees

No one assigned

Labels

ci This PR/Issue is related to the topic "CI" other PR/issue is related to third-party, scripts or other things which don't have definite label. project Issue is part of an ongoing project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] Integrate Runtime Omni Bencher

3 participants

@Dinonard @ermalkaleci @ipapandinas