Conversation
errors now tell you what we think it is if its something we know. also added and option for logging the output into a log file. a small bug was also fixed where sometimes the images have both the tag and digest so we had to remove the tag to be able to pull using docker
Contributor
|
Please can you update the README with details |
nirmalsunny
reviewed
Nov 4, 2024
sm-powell
reviewed
Nov 4, 2024
Contributor
sm-powell
left a comment
There was a problem hiding this comment.
I think the performance improvements can be in a separate PR
3fd4509 to
29987a1
Compare
sm-powell
reviewed
Nov 5, 2024
sm-powell
reviewed
Nov 5, 2024
nirmalsunny
reviewed
Nov 5, 2024
sm-powell
reviewed
Nov 6, 2024
nirmalsunny
approved these changes
Nov 6, 2024
Contributor
nirmalsunny
left a comment
There was a problem hiding this comment.
LGTM.
I have added couple of suggestions.
26b0d8d to
c13aff1
Compare
the urls i obsucred are not internal anyways
madchutney
reviewed
Nov 8, 2024
Contributor
madchutney
left a comment
There was a problem hiding this comment.
Looks good, couple of suggestions on the text.
I've not reviewed the code, just the output.
madchutney
requested changes
Nov 14, 2024
nirmalsunny
requested changes
Nov 25, 2024
nirmalsunny
approved these changes
Nov 27, 2024
madchutney
requested changes
Nov 27, 2024
Co-authored-by: Graham Hammond <graham.hammond@arm.com>
Co-authored-by: Graham Hammond <graham.hammond@arm.com>
madchutney
approved these changes
Dec 4, 2024
Contributor
madchutney
left a comment
There was a problem hiding this comment.
Thanks for the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some common error messages we get. Added the ability to log errors into a file.