✨ Improve visual output of tool#15
Merged
madchutney merged 2 commits intoArmDeveloperEcosystem:mainfrom Oct 24, 2024
Merged
Conversation
nirmalsunny
approved these changes
Oct 24, 2024
Contributor
nirmalsunny
left a comment
There was a problem hiding this comment.
LGTM. Having the icon first looks better.
I think the red exclamation mark icon gave a clearer distinction between Not Arm supported and Error occurred.
Contributor
Author
I made the change as the new icon means there is better text alignment in the output, the exclamation mark was a different size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A series of small improvements: