refactor: remove usage of monolithic arkCrypto.h#190
Merged
sleepdefic1t merged 2 commits intoArkEcosystemArchive:developfrom Nov 14, 2019
Merged
refactor: remove usage of monolithic arkCrypto.h#190sleepdefic1t merged 2 commits intoArkEcosystemArchive:developfrom
sleepdefic1t merged 2 commits intoArkEcosystemArchive:developfrom
Conversation
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
* Updated arkCrypto.h header to just be a dummy header for the sole purpose of forcing the cpp-crypto library to be linked into an Arduino sketch. * Updated tests to use specific headers instead of arkCrypto.h * Updated Arduino sample sketches to use only the headers required for the sketch.
17d28f0 to
0ed699e
Compare
- add note on ESP8266 Arduino CPU speed. - reword comment in `arkCrypto.h` to be less than 80 characters.
sleepdefic1t
approved these changes
Nov 14, 2019
|
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
|
Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days. |
|
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
purpose of forcing the cpp-crypto library to be linked into an
Arduino sketch.
for the sketch.
Checklist