Skip to content

fix: Fix transaction::to_json tests on ESP8266#180

Merged
sleepdefic1t merged 4 commits intoArkEcosystemArchive:developfrom
ciband:bug/fix_esp8266_json
Oct 30, 2019
Merged

fix: Fix transaction::to_json tests on ESP8266#180
sleepdefic1t merged 4 commits intoArkEcosystemArchive:developfrom
ciband:bug/fix_esp8266_json

Conversation

@ciband
Copy link
Contributor

@ciband ciband commented Oct 29, 2019

Summary

Broke up the transaction::to_json tests to reduce stack usage and
allow for support on esp8266.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Oct 29, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Oct 29, 2019
@ciband
fix: fix transaction::to_json tests on esp8266
d43bc93 
Broke up the transaction::to_json tests to reduce stack usage and
allow for support on esp8266.
@ciband ciband force-pushed the bug/fix_esp8266_json branch from 1f08285 to d43bc93 Compare October 29, 2019 20:59
sleepdefic1t
sleepdefic1t previously approved these changes Oct 30, 2019
View reviewed changes
@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Oct 30, 2019
@ghost
Copy link

ghost commented Oct 30, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@sleepdefic1t sleepdefic1t self-requested a review October 30, 2019 10:37
sleepdefic1t
sleepdefic1t previously approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@sleepdefic1t sleepdefic1t left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@ghost
Copy link

ghost commented Oct 30, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@sleepdefic1t sleepdefic1t self-requested a review October 30, 2019 10:41
@ghost
Copy link

ghost commented Oct 30, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@sleepdefic1t sleepdefic1t merged commit 0ccfb9e into ArkEcosystemArchive:develop Oct 30, 2019
@ghost
Copy link

ghost commented Oct 30, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Nov 1, 2019
@ghost
Copy link

ghost commented Nov 1, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@ghost ghost mentioned this pull request Nov 3, 2019
Closed
@sleepdefic1t sleepdefic1t mentioned this pull request Feb 13, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@faustbrian faustbrian Awaiting requested review from faustbrian

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

1 more reviewer

@sleepdefic1t sleepdefic1t sleepdefic1t approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: High More than 256 lines changed. Status: Member Approved The pull request has been approved by a member. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ciband @sleepdefic1t @faustbrian