Skip to content

fix: Fix transaction::to_array tests on ESP8266#178

Merged
sleepdefic1t merged 1 commit intoArkEcosystemArchive:developfrom
ciband:bug/fix_esp8266
Oct 30, 2019
Merged

fix: Fix transaction::to_array tests on ESP8266#178
sleepdefic1t merged 1 commit intoArkEcosystemArchive:developfrom
ciband:bug/fix_esp8266

Conversation

@ciband
Copy link
Contributor

@ciband ciband commented Oct 29, 2019

Summary

Broke up the transaction::to_array tests to reduce stack usage and
allow for support on esp8266.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Broke up the transaction::to_array tests to reduce stack usage and
allow for support on esp8266.
@ghost
Copy link

ghost commented Oct 29, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Oct 29, 2019
@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Oct 30, 2019
@ghost
Copy link

ghost commented Oct 30, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@sleepdefic1t sleepdefic1t merged commit a7fef39 into ArkEcosystemArchive:develop Oct 30, 2019
@ghost
Copy link

ghost commented Oct 30, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Nov 1, 2019
@ghost
Copy link

ghost commented Nov 1, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@sleepdefic1t sleepdefic1t mentioned this pull request Feb 13, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: High More than 256 lines changed. Status: Member Approved The pull request has been approved by a member. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants