chore: move packages out of source#156
Merged
faustbrian merged 7 commits intoArkEcosystemArchive:developfrom Oct 8, 2019
sleepdefic1t:chore/move-packages-oos
Merged
chore: move packages out of source#156faustbrian merged 7 commits intoArkEcosystemArchive:developfrom sleepdefic1t:chore/move-packages-oos
faustbrian merged 7 commits intoArkEcosystemArchive:developfrom
sleepdefic1t:chore/move-packages-oos
Conversation
Contributor
|
@sleepdefic1t platformio failing |
faustbrian
approved these changes
Oct 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
External libraries are currently submoduled in the source tree which leads to more complex builds and makes maintaining and debugging more difficult.
This PR moves external libraries to
externin the root dir and drops submodules in favor CMake methods of fetching dependencies.Specifically, this PR does the following:
Checklist
Additional Comments
PIO build failure is resolved in #155