chore(transaction): update amounts json#111
Merged
faustbrian merged 5 commits intoArkEcosystemArchive:developfrom Jul 16, 2019
sleepdefic1t:chore(transaction)/update-amounts-json
Merged
chore(transaction): update amounts json#111faustbrian merged 5 commits intoArkEcosystemArchive:developfrom sleepdefic1t:chore(transaction)/update-amounts-json
faustbrian merged 5 commits intoArkEcosystemArchive:developfrom
sleepdefic1t:chore(transaction)/update-amounts-json
Conversation
This PR updates transaction json values to match Core 2.5. - transaction `amount` Json as string. - transaction `fee` Json as string. - updates tests to match changes. - cleanup transaction tests.
Contributor
|
There are a few more fields that need changing. You can check @supaiku0 Rust PR at https://github.com/ArkEcosystem/rust-client/pull/45/files. |
Codecov Report
@@ Coverage Diff @@
## develop #111 +/- ##
========================================
Coverage 91.52% 91.52%
========================================
Files 30 30
Lines 861 861
========================================
Hits 788 788
Misses 73 73
Continue to review full report at Codecov.
|
Contributor
Author
|
There's no modeling of API responses, and no Should be good now 👍 |
faustbrian
approved these changes
Jul 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates transaction json values to match Core 2.5.
amountJson as string.feeJson as string.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
The PR fulfills these requirements:
developbranch, not themasterbranch