fix(manifest): Correct Supported Platforms#107
Merged
faustbrian merged 2 commits intoArkEcosystemArchive:developfrom Jul 4, 2019
sleepdefic1t:fix(manifest)/correct-supported-platforms
Merged
fix(manifest): Correct Supported Platforms#107faustbrian merged 2 commits intoArkEcosystemArchive:developfrom sleepdefic1t:fix(manifest)/correct-supported-platforms
faustbrian merged 2 commits intoArkEcosystemArchive:developfrom
sleepdefic1t:fix(manifest)/correct-supported-platforms
Conversation
The current library manifest uses a wildcard `*` for the `platforms` value incorrectly signifying that it supports all platforms. This is incorrect as the Cpp SDK's only officially support the espressif8266 & espressif32 platforms. This PR corrects this discrepancy.
Codecov Report
@@ Coverage Diff @@
## develop #107 +/- ##
========================================
Coverage 91.52% 91.52%
========================================
Files 30 30
Lines 861 861
========================================
Hits 788 788
Misses 73 73Continue to review full report at Codecov.
|
This was referenced Jul 3, 2019
faustbrian
approved these changes
Jul 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by @yhyuan in #104,
the current library manifest uses a wildcard
*for theplatformsvalue signifying that it supports all platforms.This is incorrect as the Cpp SDK's only officially support the espressif8266 & espressif32 platforms. This PR corrects that discrepancy.
What kind of change does this PR introduce?
Affects external package manager library manifest
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranch