test: increase coverage#93
Merged
faustbrian merged 2 commits intoArkEcosystemArchive:masterfrom May 25, 2019
sleepdefic1t:test/improve-coverage
Merged
test: increase coverage#93faustbrian merged 2 commits intoArkEcosystemArchive:masterfrom sleepdefic1t:test/improve-coverage
faustbrian merged 2 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:test/improve-coverage
Conversation
- remove unnecessary methods in `host` class. - use string instead of char* in `Host::ip`. - improve testing of `host` class. - improve testing of `paths` class. - update connection test to use string. - improve testing of `host` class. - update the change log.
Contributor
Author
|
@faustbrian Passing tests here: 100% CodeCov: |
Contributor
Author
|
gonna try something.. |
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
=======================================
+ Coverage 96.4% 100% +3.6%
=======================================
Files 14 14
Lines 250 245 -5
=======================================
+ Hits 241 245 +4
+ Misses 9 0 -9
Continue to review full report at Codecov.
|
faustbrian
approved these changes
May 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR primarily deals with improving test coverage.
Specifically, this PR does the following:
hostclass.Host::ip.hostclass.pathsclass.hostclass.Types of changes
Improves class members and test coverage to 100%.
Checklist