Skip to content

style: Improve Formatting and Maintainability#92

Merged
faustbrian merged 1 commit intoArkEcosystemArchive:masterfrom
sleepdefic1t:style/improve-formatting-and-maintainability
May 23, 2019
Merged

style: Improve Formatting and Maintainability#92
faustbrian merged 1 commit intoArkEcosystemArchive:masterfrom
sleepdefic1t:style/improve-formatting-and-maintainability

Conversation

@sleepdefic1t
Copy link
Contributor

Proposed changes

This PR improves code formatting and maintainability.

Specifically, this PR does the following:

  • fixes exit statement in circleci/clang_tidy.sh.
  • fixes dirname statement in ARDUINO_IDE.sh.
  • fixes return statement in src/host/host.cpp.
  • updates formatting in src/ and test/ classes.
  • removes empty line @ transactions.h ln38.
  • removes empty line @ test\http\http.cp ln70.
  • removes IoT WiFi setup in test/iot/test_main.cpp.
  • updates change log.

Types of changes

  • Other... Please describe:

Style and maintainability.

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

- fix exit statement in `circleci/clang_tidy.sh`.
- fix dirname statement in `ARDUINO_IDE.sh`.
- fix return statement in `src/host/host.cpp`.
- update formatting in `src/` and `test/` classes.
- remove empty line @ `transactions.h` ln38.
- remove empty line @ `test\http\http.cp` ln70.
- remove IoT WiFi setup in `test/iot/test_main.cpp`.
- update change log.
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Standards The issue reports problems with the compliance of contribution guidelines or code standards. labels May 22, 2019
@sleepdefic1t
Copy link
Contributor Author

@faustbrian
Not sure whats up with CI, it did this in C++ Crypto too.

Passing tests are here:
circleci/sleepdefic1t/cpp-client/style-improve-formatting-and-maintainability

This one's ready when you are.

@faustbrian faustbrian merged commit e63837f into ArkEcosystemArchive:master May 23, 2019
@sleepdefic1t sleepdefic1t deleted the style/improve-formatting-and-maintainability branch May 23, 2019 16:33
This was referenced Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Undetermined Needs specialized, in-depth review. Type: Standards The issue reports problems with the compliance of contribution guidelines or code standards.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants