Skip to content

chore: drop Hunter Package Manager#90

Merged
faustbrian merged 1 commit intoArkEcosystemArchive:masterfrom
sleepdefic1t:chore/drop-hunter
May 16, 2019
Merged

chore: drop Hunter Package Manager#90
faustbrian merged 1 commit intoArkEcosystemArchive:masterfrom
sleepdefic1t:chore/drop-hunter

Conversation

@sleepdefic1t
Copy link
Contributor

Proposed changes

This PR drops Hunter Package Manager in favor of git submodules.

Specifically, this PR does the following:

  • drops Hunter & Hunter files.
  • adds cURL as a git submodule.
  • updates CMakeLists.txt files to find cURL dep.
  • updates relevant documentation.
  • updates codecov ignore path.
  • adds openssl to CI dep install
  • updates the changelog.

This also resolves #45

Types of changes

  • Build (changes that affect the build system)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)

drop Hunter & Hunter files.
add cURL git submodule.
update CMakeLists.txt files to find cURL dep.
update relevant documentation.
update codecov ignore path.
add openssl to CI 'apt-get' install
update the changelog.
@ghost ghost added Complexity: High More than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels May 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #90   +/-   ##
======================================
  Coverage    96.4%   96.4%           
======================================
  Files          14      14           
  Lines         250     250           
======================================
  Hits          241     241           
  Misses          9       9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecda959...a1de467. Read the comment docs.

@faustbrian faustbrian merged commit 628436c into ArkEcosystemArchive:master May 16, 2019
@sleepdefic1t sleepdefic1t deleted the chore/drop-hunter branch May 23, 2019 16:33
@sleepdefic1t sleepdefic1t mentioned this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: High More than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor curl dependency

3 participants