Skip to content

misc: add Arduino Sketch path to Library Config#67

Merged
faustbrian merged 3 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:misc/add-arduino-sketch-path
Feb 6, 2019
Merged

misc: add Arduino Sketch path to Library Config#67
faustbrian merged 3 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:misc/add-arduino-sketch-path

Conversation

@sleepdefic1t
Copy link
Contributor

@sleepdefic1t sleepdefic1t commented Feb 5, 2019

Proposed changes

This PR primarily adds the Arduino Sketch/Example path to library.json.
This allows external package managers to properly list our examples.

It also corrects the platformio_example path.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

adds to and updates library configuration file

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@sleepdefic1t
misc: add arduino sketch path to config
d12af6f 
- this change also fixes the 'platformio_example' path
@sleepdefic1t
Revert "misc: add arduino sketch path to config"
7e952a5 
This reverts commit d12af6f.
@sleepdefic1t
misc: add arduino sketch path to config
d6f5f14 
- this change also fixes the 'platformio_example' path
@ghost
Copy link

ghost commented Feb 5, 2019

@sleepdefic1t Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ghost
Copy link

ghost commented Feb 5, 2019

@faustbrian @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io
Copy link

codecov-io commented Feb 5, 2019

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   77.67%   77.67%           
=======================================
  Files          22       22           
  Lines         318      318           
=======================================
  Hits          247      247           
  Misses         71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aebc72...d6f5f14. Read the comment docs.

@sleepdefic1t sleepdefic1t mentioned this pull request Feb 5, 2019
Merged
12 tasks
@ghost
Copy link

ghost commented Feb 6, 2019

@sleepdefic1t A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Feb 6, 2019
@faustbrian faustbrian merged commit 9a85986 into ArkEcosystemArchive:master Feb 6, 2019
@ArkEcosystemArchive ArkEcosystemArchive deleted a comment Feb 6, 2019
@ghost ghost mentioned this pull request Feb 11, 2019
Closed
@sleepdefic1t sleepdefic1t deleted the misc/add-arduino-sketch-path branch February 15, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@faustbrian faustbrian faustbrian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Status: Contributor Approved The pull request has been approved by a contributor.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sleepdefic1t @codecov-io @faustbrian