fix: rename helpers#65
Merged
faustbrian merged 1 commit intoArkEcosystemArchive:masterfrom Jan 28, 2019
sleepdefic1t:fix/rename-helpers
Merged
fix: rename helpers#65faustbrian merged 1 commit intoArkEcosystemArchive:masterfrom sleepdefic1t:fix/rename-helpers
faustbrian merged 1 commit intoArkEcosystemArchive:masterfrom
sleepdefic1t:fix/rename-helpers
Conversation
Cpp-Client uses the header 'helpers/helpers.h'. Cpp-Crypto also uses this 'helpers/helpers.h' naming. These headers are not identical and contain only “helper” functions specific to its library. When both Cpp-Client & Cpp-Crypto are included in the same project, it results in a name collision causing one of the headers to be dropped. This PR renames 'helpers/helpers.h' to 'helpers/client_helpers.h’, and resolves the name collision.
Contributor
Author
|
ArkEcosystem/cpp-crypto #51 matches this revised naming. |
12 tasks
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 78.45% 78.45%
=======================================
Files 22 22
Lines 311 311
=======================================
Hits 244 244
Misses 67 67
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Jan 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Cpp-Client uses the header 'helpers/helpers.h'.
Cpp-Crypto also uses this 'helpers/helpers.h' naming.
These headers are not identical and contain only “helper” functions specific to its library.
When both Cpp-Client & Cpp-Crypto are included in the same project, it results in one of the headers being dropped.
This PR renames 'helpers/helpers.h' to 'helpers/client_helpers.h’, and resolves the issue.
Types of changes
Checklist
Further comments
There will also be a PR in ArkEcosystem/Cpp-Crypto to match this revised naming.