Skip to content

fix: Node Tests#63

Merged
faustbrian merged 2 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:fix/node-tests
Jan 28, 2019
Merged

fix: Node Tests#63
faustbrian merged 2 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:fix/node-tests

Conversation

@sleepdefic1t
Copy link
Contributor

Proposed changes

Missing comment closure resulted in skipped test.

This PR adds the missing closure to resolve this issue.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

- missing comment closure resulted in skipped test.
@sleepdefic1t
Copy link
Contributor Author

Linux CI failures aren't a result of this PR.
Looks like a CI error downloading unrelated OS dependencies.

@faustbrian faustbrian merged commit d714a37 into ArkEcosystemArchive:master Jan 28, 2019
@sleepdefic1t sleepdefic1t mentioned this pull request Feb 5, 2019
12 tasks
@sleepdefic1t sleepdefic1t deleted the fix/node-tests branch February 15, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants