Add haptic feedback support for lyrics screen, shuffle/repeat buttons and add settings toggle#643
Merged
Conversation
…shuffle/repeat buttons and add settings toggle
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an app-level “Haptics/Vibration” preference and wires it into multiple interactive UI elements (player controls, queue controls, FAB, etc.) to conditionally trigger haptic feedback.
Changes:
- Introduces
EnableHapticFeedbackKeypreference key and a new Appearance settings toggle with icon/text resources. - Adds conditional haptic feedback triggers across player/queue/lyrics/AOD/mini-player interactions.
- Wraps
LocalHapticFeedbackinMainActivityto centrally respect the new preference (in addition to directView.performHapticFeedbackcalls elsewhere).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds UI strings for the new haptics setting. |
| app/src/main/res/drawable/vibration.xml | Adds a vibration icon used in settings. |
| app/src/main/kotlin/moe/koiverse/archivetune/ui/screens/settings/AppearanceSettings.kt | Adds a settings switch for enabling/disabling haptics. |
| app/src/main/kotlin/moe/koiverse/archivetune/ui/player/Thumbnail.kt | Adds conditional haptics on thumbnail double-tap. |
| app/src/main/kotlin/moe/koiverse/archivetune/ui/player/QueueComponents.kt | Adds conditional haptics on queue/player header controls and updates view haptics flag. |
| app/src/main/kotlin/moe/koiverse/archivetune/ui/player/Queue.kt | Gates existing long-press haptics and adds click haptics for some controls. |
| app/src/main/kotlin/moe/koiverse/archivetune/ui/player/PlayerComponents.kt | Adds conditional haptics to playback control interactions. |
| app/src/main/kotlin/moe/koiverse/archivetune/ui/player/Player.kt | Adds conditional haptics to mini overlay gestures via composed. |
| app/src/main/kotlin/moe/koiverse/archivetune/ui/player/MiniPlayerComponents.kt | Adds conditional haptics to mini-player swipe and button clicks; updates view haptics flag. |
| app/src/main/kotlin/moe/koiverse/archivetune/ui/player/LyricsScreen.kt | Adds conditional haptics for lyrics screen playback controls and tweaks layout. |
| app/src/main/kotlin/moe/koiverse/archivetune/ui/player/AodPlayerScreen.kt | Adds conditional haptics to AOD controls. |
| app/src/main/kotlin/moe/koiverse/archivetune/ui/component/HideOnScrollFAB.kt | Adds conditional haptics to FAB; updates view haptics flag. |
| app/src/main/kotlin/moe/koiverse/archivetune/constants/PreferenceKeys.kt | Defines the new EnableHapticFeedbackKey. |
| app/src/main/kotlin/moe/koiverse/archivetune/MainActivity.kt | Overrides LocalHapticFeedback to respect the preference globally (within Compose). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
rukamori
approved these changes
May 21, 2026
|
This shit doesn't work on my machine (CMF Phone 2 pro by nothing) |
Contributor
Author
|
informative feedback |
|
make nix flake for this bcs nix would fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first of all, i'm very sorry that i forgot permission in previous PR, it worked on my device so i didn't know that
anyways, in this commit i added haptics for controls on lyrics screen, shuffle and repeat buttons, added global haptics toggle in misc appearance settings tab, i tested it and it works as intended
hope this will be merged
thanks for your hard work again, i enjoy using and translating ArchiveTune!