Add submodules and links #587
Merged
+15
−653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I added relative soft links to the python module inside the submodule to avoid touching the imports in the code. Not sure if any problems could arise with the multiple packaging options. |
Member
|
Did you run the tests on this? It doesn't appear to be working: |
Contributor
Author
|
@pirate ArchiveBox tests run ok. Pytest is discovering django-taggit owns tests and failing due to a missing test dependency. Will search how to configure pytest to avoid tests inside vendored. |
Contributor
Author
|
Errors in tests fixed ignoring vendored modules tests #588 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds vendored code as git submodules with links
Related issues
#581
Changes these areas