Fix missing display: flex on caddl thumbnail inner div #1728
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a CSS issue in the CAD/3D asset thumbnail template where flex properties were being applied without
display: flex.Problem
The inner div in
archivebox/plugins/caddl/templates/thumbnail.htmlhadflex-direction: columnandalign-items: centerstyles, but was missingdisplay: flex. Without the display property set to flex, these flex properties have no effect, so the emoji (🧊) and "3D Asset" text weren't stacking vertically as intended.Solution
Added
display: flex;to the inner div's style attribute so the flexbox layout takes effect and the content stacks correctly.Changes
archivebox/plugins/caddl/templates/thumbnail.html: Addeddisplay: flex;to line 3Summary by cubic
Fixed the CAD/3D asset thumbnail layout by adding display: flex to the inner div so flexbox applies and the 🧊 emoji and "3D Asset" label stack vertically and stay centered.
Written for commit a01bdd4. Summary will update automatically on new commits.