Add config options to initialize admin user on first run without prompting #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good! Two small changes:
|
pirate
requested changes
Oct 18, 2023
pirate
reviewed
Oct 18, 2023
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the option to create an admin user on initialization without prompting. The configuration options
ARCHIVEBOX_USERNAMEandARCHIVEBOX_PASSWORDare only checked on first initialization (if there's noindex.sqlite3file). The admin user is only created if both options are present.I'm not sure if there are some other use cases that exist that are not covered by this implementation, please let me know if so.
Related issues
#734
Changes these areas