Fix archive_org icon "exists" #1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where if you make a snapshot while SAVE_ARCHIVE_DOT_ORG is enabled then the archive_org link will always show as active, despite that being explicitly disabled. This is because of a miscalculation of the "exists" variable which ends up being set to "None" instead of "False". Screenshot included showing this -- it should have class="exists-False" but it's class="exists-None".
Related issues
I didn't make an issue for this as when I noticed the problem I just fixed it instead of reporting anything.
Changes these areas
Let me know if there's anything I could do to help get this merged.