Skip to content

test: add test for postgres driver handling of generic lists and ARRAY_OF_FLOATS#2039

Merged
robfrank merged 3 commits into
ArcadeData:mainfrom
ExtReMLapin:python_tests_array_of_floats
Mar 4, 2025
Merged

test: add test for postgres driver handling of generic lists and ARRAY_OF_FLOATS#2039
robfrank merged 3 commits into
ArcadeData:mainfrom
ExtReMLapin:python_tests_array_of_floats

Conversation

@ExtReMLapin

Copy link
Copy Markdown
Contributor

What does this PR do?

Test checking if the pg driver returns an actual list instead of a string for an ARRAY_OF_FLOATS

Motivation

test for pr #2017

Related issues

A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.

Additional Notes

Anything else we should know when reviewing?

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@ExtReMLapin ExtReMLapin changed the title test: add test for postgres driver handling of array of floats test: add test for postgres driver handling of generic lists and ARRAY_OF_FLOATS Mar 4, 2025
@ExtReMLapin ExtReMLapin marked this pull request as ready for review March 4, 2025 08:27
@ExtReMLapin

ExtReMLapin commented Mar 4, 2025

Copy link
Copy Markdown
Contributor Author

As of today those tests should FAIL because #2017 is not merged.

I tested it (outside of pytest) on my fork and there is no assert exception raised

@robfrank robfrank merged commit f5341e4 into ArcadeData:main Mar 4, 2025
@ExtReMLapin ExtReMLapin deleted the python_tests_array_of_floats branch March 4, 2025 12:40
import json
import string

import pytest

@ExtReMLapin ExtReMLapin Mar 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, reimported

@lvca lvca added this to the 25.3.1 milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants