Distinguish skipped instructions from invalid instructions#3
Merged
a2geek merged 1 commit intoAppleCommander:mainfrom Oct 28, 2023
Merged
Conversation
Contributor
|
I like it. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disassembler display both skipped instructions and invalid instructions as
???.For example,
acdasm c600 –a=0xc600 –-offset=4Apple II Programmers are used to interpreting
???as invalid opcodes. In this listing, The first opcodeA2is not invalid. It is the opcode ofLDX #instruction.I have renamed the class
InvalidInstructiontoSkippedInstructionand display the mnemonic as---. Here is the sample output.