Use own copy of useWindowDimensions#139
Merged
janicduplessis merged 1 commit intoAppAndFlow:masterfrom Aug 24, 2020
tchayen:copy-use-window-dimensions
Merged
Use own copy of useWindowDimensions#139janicduplessis merged 1 commit intoAppAndFlow:masterfrom tchayen:copy-use-window-dimensions
janicduplessis merged 1 commit intoAppAndFlow:masterfrom
tchayen:copy-use-window-dimensions
Conversation
Instead of making the lib incompatible with React Native < 0.61, this commit creates a local copy of the hook.
Collaborator
|
Hmm strange, I was able to successfully run the examples from a clean repo a few days ago. What version of xcode do you have, it could be related to this? |
Collaborator
|
I will merge and test on my end, code looks good! Thanks a lot! |
janicduplessis
approved these changes
Aug 24, 2020
Collaborator
|
Works great, released as v3.1.7 |
Contributor
Author
|
I am using version Thanks for merging! |
This was referenced Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As requested by @janicduplessis in this comment.
Test Plan
@janicduplessis I am having trouble running the example app on iOS. On startup I face error
Operator 'abs' not found, linking tonode_modules/react-native-reanimated/ios/Nodes/REAOperatorNode.m#L94. Does currentmasterwork properly for you?I will check Android in a moment, but still opening as a draft since I am unable to verify on iOS.