Skip to content

Cleanup the Polly and Polly.Specs codebase#2467

Merged
martincostello merged 10 commits intomainfrom
gh-1290
Jan 28, 2025
Merged

Cleanup the Polly and Polly.Specs codebase#2467
martincostello merged 10 commits intomainfrom
gh-1290

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Jan 28, 2025

  • Suppress extant occurences of code analysis warnings inline in the code and re-enable suppressed rules.
  • Fix remaining IDE/formatting suggestions in Polly.Specs.

Resolves #1290.

@martincostello
Apply IDE suggestions
6936d18 
Apply remaining IDE suggestions for code simplification and clean-up in Polly.Specs.
@martincostello
Fix S3215
041b40c 
- Suppress occurrences of S3215.
- Re-enable the S3215 rule.
@martincostello
Enable S2223
56c6b3e 
- Suppress extant occurrences of S2223.
- Re-enable S2223.
@martincostello
Enable CA1051
a553281 
- Suppress extant occurrences of CA1051.
- Enable CA1051.
@martincostello
Enable CA1724
c6ab86e 
- Suppress extant occurrences of CA1724.
- Re-enable CA1724.
@martincostello
Enable CA1064
8a9dab1 
- Suppress extant occurrence of CA1064.
- Re-enable CA1064.
@martincostello
Re-enable CA1031
1d4d496 
- Suppress extant occurrences of CA1031.
- Re-enable CA1031.
@martincostello
Enable CA1063
474f8e8 
- Suppress extant occurrences of CA1063.
- Re-enable CA1063.
@martincostello martincostello mentioned this pull request Jan 28, 2025
Closed
@martincostello
Fix build
4c795f3 
Add missing CA1063 suppressions.
@codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (7148503) to head (ab4d596).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2467   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         312      312           
  Lines        7464     7465    +1     
  Branches     1121     1121           
=======================================
+ Hits         6371     6372    +1     
  Misses        908      908           
  Partials      185      185
Flag Coverage Δ
linux 85.35% <100.00%> (+<0.01%) ⬆️
macos 85.35% <100.00%> (+<0.01%) ⬆️
windows 85.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
Fix IDE0055 warnings
ab4d596 
Fix IDE0055 warnings on Windows.
@martincostello martincostello marked this pull request as ready for review January 28, 2025 10:54
@martincostello martincostello enabled auto-merge (rebase) January 28, 2025 10:54
@martincostello martincostello merged commit 7d4bfd8 into main Jan 28, 2025
24 checks passed
@martincostello martincostello deleted the gh-1290 branch January 28, 2025 11:22
This was referenced Jul 22, 2025
Closed
Closed
Closed
This was referenced Jul 30, 2025
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Merged
This was referenced Dec 8, 2025
Open
Closed
This was referenced Dec 15, 2025
Closed
Closed
Merged
Open
This was referenced Jan 1, 2026
Open
Open
Merged
This was referenced Jan 12, 2026
Merged
Open
Open
Merged
Closed
This was referenced Jan 19, 2026
Merged
Merged
Merged
This was referenced Jan 29, 2026
Closed
Open
Merged
Open
This was referenced Feb 16, 2026
Merged
Merged
This was referenced Feb 23, 2026
Closed
Closed
This was referenced Mar 2, 2026
Closed
Open
Open
Open
@dependabot dependabot bot mentioned this pull request Mar 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CI/build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cleanup the Polly and Polly.Specs codebase

1 participant

@martincostello