Skip to content

Add TelemetrySource to ExecutionRejectedException#2346

Merged
martincostello merged 6 commits intoApp-vNext:mainfrom
peter-csala:add-telemetry-source-to-rate-limiter-rejected-exception
Oct 23, 2024
Merged

Add TelemetrySource to ExecutionRejectedException#2346
martincostello merged 6 commits intoApp-vNext:mainfrom
peter-csala:add-telemetry-source-to-rate-limiter-rejected-exception

Conversation

@peter-csala
Copy link
Contributor

@peter-csala peter-csala commented Oct 15, 2024 •
edited
Loading

Pull Request

The issue or feature being addressed

#2345

Details on the issue fix or feature implementation

Done

  • Added TelemetrySource property to the ExecutionRejectedException
  • Extended ResilienceStrategyTelemetry with a UpdateTelemetrySource method
  • Updated several strategies to populate TelemetrySource on the thrown exception

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@peter-csala peter-csala force-pushed the add-telemetry-source-to-rate-limiter-rejected-exception branch from 92e3f2e to cd0b75c Compare October 16, 2024 10:53
@codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.43%. Comparing base (14ac109) to head (167592c).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2346      +/-   ##
==========================================
+ Coverage   85.40%   85.43%   +0.02%     
==========================================
  Files         313      313              
  Lines        7467     7482      +15     
  Branches     1125     1125              
==========================================
+ Hits         6377     6392      +15     
  Misses        745      745              
  Partials      345      345
Flag Coverage Δ
linux 85.43% <100.00%> (+0.02%) ⬆️
macos 85.43% <100.00%> (+0.02%) ⬆️
windows 85.40% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

peter-csala
peter-csala commented Oct 16, 2024
View reviewed changes
peter-csala
peter-csala commented Oct 16, 2024
View reviewed changes
martincostello
martincostello reviewed Oct 17, 2024
View reviewed changes
martincostello
martincostello reviewed Oct 17, 2024
View reviewed changes
@peter-csala peter-csala marked this pull request as ready for review October 17, 2024 16:09
@peter-csala peter-csala changed the title [DRAFT] Add TelemetrySource to RateLimiterRejectedException Add TelemetrySource to RateLimiterRejectedException Oct 17, 2024
martintmk
martintmk reviewed Oct 20, 2024
View reviewed changes
@martintmk martintmk mentioned this pull request Oct 21, 2024
Closed
4 tasks
@peter-csala peter-csala force-pushed the add-telemetry-source-to-rate-limiter-rejected-exception branch from 1d98646 to 4244d2d Compare October 21, 2024 15:07
@peter-csala peter-csala force-pushed the add-telemetry-source-to-rate-limiter-rejected-exception branch from 4244d2d to ef63b0b Compare October 21, 2024 15:09
@peter-csala peter-csala changed the title Add TelemetrySource to RateLimiterRejectedException Add TelemetrySource to ExecutionRejectedException Oct 21, 2024
@peter-csala peter-csala marked this pull request as draft October 21, 2024 15:12
@peter-csala peter-csala changed the title Add TelemetrySource to ExecutionRejectedException [DRAFT] Add TelemetrySource to ExecutionRejectedException Oct 21, 2024
@peter-csala peter-csala marked this pull request as ready for review October 22, 2024 08:48
@peter-csala peter-csala changed the title [DRAFT] Add TelemetrySource to ExecutionRejectedException Add TelemetrySource to ExecutionRejectedException Oct 22, 2024
@martintmk
Copy link
Contributor

martintmk commented Oct 22, 2024

LGTM, great job!

How about to update our docs too in follow-up?

@martintmk
Copy link
Contributor

martintmk commented Oct 23, 2024

@martincostello is this ok to merge?

martincostello
martincostello reviewed Oct 23, 2024
View reviewed changes
@martincostello martincostello added this to the v8.5.0 milestone Oct 23, 2024
martincostello
martincostello approved these changes Oct 23, 2024
View reviewed changes
@peter-csala @martincostello
Update src/Polly.Core/Telemetry/ResilienceStrategyTelemetry.cs
167592c 
Co-authored-by: Martin Costello <martin@martincostello.com>
@martincostello martincostello enabled auto-merge (squash) October 23, 2024 12:24
This was referenced Oct 23, 2025
Open
Merged
Merged
Closed
This was referenced Nov 3, 2025
Merged
Merged
This was referenced Nov 24, 2025
Open
Open
Open
Open
This was referenced Dec 8, 2025
Open
Closed
This was referenced Dec 15, 2025
Closed
Merged
This was referenced Jan 1, 2026
Open
Open
Merged
This was referenced Jan 12, 2026
Merged
Open
Open
This was referenced Jan 19, 2026
Merged
Merged
Merged
This was referenced Jan 29, 2026
Closed
Merged
@dependabot dependabot bot mentioned this pull request Feb 16, 2026
Merged
This was referenced Feb 24, 2026
Closed
Closed
This was referenced Mar 5, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martincostello martincostello martincostello approved these changes

@martintmk martintmk martintmk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v8.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@peter-csala @martintmk @martincostello