Change styles and add background ease#22
Merged
CMEONE merged 6 commits intoApp-Dev-League:mainfrom Jul 7, 2022
cytronicoder:main
Merged
Change styles and add background ease#22CMEONE merged 6 commits intoApp-Dev-League:mainfrom cytronicoder:main
CMEONE merged 6 commits intoApp-Dev-League:mainfrom
cytronicoder:main
Conversation
- Update colors in both roots to accommodate some material guidelines - Added background and color ease to body when changing themes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
Note: I believe that you still need to build it before one can view it on the browser. |
Contributor
Author
|
I have pushed the latest build to this PR just now - it should be good to go 🚀 |
gadhagod
approved these changes
Jul 7, 2022
CMEONE
requested changes
Jul 7, 2022
Member
CMEONE
left a comment
There was a problem hiding this comment.
It seems like the changes in src/index.html overwrite dark mode colors as well, is it possible to change those colors back to the original colors? If it's possible to make the new colors only apply in light mode, that might also work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on the Discord server, I edited all the colors in both themes and added a smoother transition animation from one theme to another when the toggle is clicked.
Commits