Merged
Conversation
spoonincode
reviewed
Mar 22, 2023
| add_test(NAME test_read_only_trx COMMAND plugins/producer_plugin/test/test_read_only_trx WORKING_DIRECTORY ${CMAKE_BINARY_DIR}) | ||
|
|
||
| add_executable( test_block_timing_util test_block_timing_util.cpp ) | ||
| target_link_libraries( test_block_timing_util producer_plugin eosio_testing ) No newline at end of file |
Contributor
There was a problem hiding this comment.
should this have been add_test()ed?
Contributor
|
|
heifner
suggested changes
Mar 24, 2023
plugins/producer_plugin/include/eosio/producer_plugin/block_timing_util.hpp
Outdated
Show resolved
Hide resolved
heifner
reviewed
Mar 24, 2023
This was referenced Mar 24, 2023
arhag
suggested changes
Mar 28, 2023
plugins/producer_plugin/include/eosio/producer_plugin/producer_plugin.hpp
Show resolved
Hide resolved
# Conflicts: # plugins/producer_plugin/producer_plugin.cpp
# Conflicts: # plugins/producer_plugin/producer_plugin.cpp
heifner
approved these changes
Apr 10, 2023
arhag
approved these changes
Apr 11, 2023
This was referenced Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the start times for block producing. Before this PR, a producer always starts producing each block at the time point of the multiple of config::block_interval_us (i.e. 500 ms) and spend at most
cpu-effort-percent(i.e. 80 by default, so it is 400 ms out of 500 ms) to produce each block. Therefore it leaves 100 ms idle time in between each block producing. In this PR, we leave no gap in between block producing so that the last block in each production round can reach the next producer earlier so that the next producer can start producing on schedule.Removed configuration options:
The schema for Runtime_Options has changed to
Resolves #726