Skip to content

[5.0] Revert "Fix base64 encoding"#1886

Merged
heifner merged 2 commits intorelease/5.0from
GH-1883-base64-rm-5.0
Nov 13, 2023
Merged

[5.0] Revert "Fix base64 encoding"#1886
heifner merged 2 commits intorelease/5.0from
GH-1883-base64-rm-5.0

Conversation

@heifner
Copy link
Contributor

@heifner heifner commented Nov 10, 2023

Reverts #1482 as it causes issues with backward compatibility with older version of nodeos. See #1883.
An alternative fix will be provided in a follow-on PR.

Re-open #1461
Resolves #1883

@heifner heifner added the OCI Work exclusive to OCI team label Nov 10, 2023
@heifner heifner merged commit de71459 into release/5.0 Nov 13, 2023
@heifner heifner deleted the GH-1883-base64-rm-5.0 branch November 13, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCI Work exclusive to OCI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5.0 cleos cannot handle reponses from pre-5.0 nodes containing base64 (and vice versa I believe)

3 participants