[5.0] Benchmark BLS host functions#1884
Merged
arhag merged 12 commits intorelease/5.0from Nov 14, 2023
Merged
Conversation
…rent between benchmarked functions
heifner
suggested changes
Nov 9, 2023
…osio::chain::transaction_context
… chain->control.get() directly instead
…functions will never reach deadline
… as they are not needed
heifner
approved these changes
Nov 9, 2023
spoonincode
reviewed
Nov 13, 2023
| target_link_libraries( benchmark eosio_testing fc Boost::program_options bn256) | ||
| target_include_directories( benchmark PUBLIC | ||
| "${CMAKE_CURRENT_SOURCE_DIR}" | ||
| "${CMAKE_CURRENT_BINARY_DIR}/../unittests/include" |
Contributor
There was a problem hiding this comment.
We don't need to fix this now (or even when merging to main) but we should try to avoid these sort of declarations. We probably want a target similar to eosio_testing_contracts,
leap/libraries/testing/CMakeLists.txt
Lines 39 to 41 in 581cd2b
Contributor
Author
There was a problem hiding this comment.
Thanks @spoonincode. I was doing the cleos set code issue yesterday and not getting around with this. As the PR has already merged into 5.0, for cleaner tracking, I will merge the PR to main as is, and use your suggested way later.
arhag
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add benchmarking of BLS host functions into
LeapBenchmark suites. Those host functions are directly benchmarked without using CDT wrappers.Use
benchmark/benchmark -f blsto benchmark. A sample result looks likeResolves #1854