Skip to content

[4.0] HTTP: Check for connection_reset#1663

Merged
heifner merged 1 commit intorelease/4.0from
GH-1661-conn-reset-4.0
Sep 21, 2023
Merged

[4.0] HTTP: Check for connection_reset#1663
heifner merged 1 commit intorelease/4.0from
GH-1661-conn-reset-4.0

Conversation

@heifner
Copy link
Contributor

@heifner heifner commented Sep 21, 2023

When running performance tests on read-only transaction execution, the node generated many errors of read_header: Connection reset by peer and didn't make additional progress.

Boost beast http session checks for http::error::end_of_stream || asio::error::connection_reset in on_read and executes do_eof() to shutdown the connection. on_read_header was checking for http::error::end_of_stream but not asio::error::connection_reset. This PR changes on_read_header to also check for asio::error::connection_reset.

Resolves #1661

@heifner heifner changed the title [4.0] Check for connection_reset similar to on_read [4.0] HTTP: Check for connection_reset Sep 21, 2023
@heifner heifner linked an issue Sep 21, 2023 that may be closed by this pull request
Copy link
Contributor

@spoonincode spoonincode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for 4.0 but I might have more commentary on the change to main

@heifner heifner merged commit cdfe867 into release/4.0 Sep 21, 2023
@heifner heifner deleted the GH-1661-conn-reset-4.0 branch September 21, 2023 18:10
@heifner heifner added the OCI Work exclusive to OCI team label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCI Work exclusive to OCI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Under heavy load http read_header 'Connection reset by peer'

3 participants