Conversation
…ccording to ChatGPT...ignore this file
Author
|
PRed upstream in tibdex/github-app-token pull request 61. |
This was referenced Feb 2, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request attempts to address CVE-2022-46175 - Prototype Pollution in JSON5 via Parse Method by using the
resolutionsfield in thepackage.jsonto forceyarnto select a version of this transitive dependency that has been patched for this CVE regardless of what version the parent dependency is asking for.I believe this is a reasonable approach because the difference between what was requested and what is forced is only one or two patch versions.
That being said, a better solution would be to update the parents causing the transitive dependencies requesting the old package version instead of using
resolutions.